Updated wxwin.m4 macro regex to detect x.x.x[...] versions (PR #23402)
Matthew White
Hello,
Is it possible to add the possibility to detect wxWidgets versions like 3.2.2.1?
There are problems compiling xCHM on Gentoo GNU/Linux with wxGTK-3.2.2.1 installed: https://bugs.gentoo.org/895982
The current wxwin.m4 macro fails to detect x.x.x[...] versions:
echo "3.2.2.1" | sed 's/\([0-9]*\).\([0-9]*\).\([0-9]*\)/\1/'
This PR simply adds a capture group to glob the [...] part in x.x.x[...]:
echo "3.2.2.1" | sed -r 's/^([0-9]+)\.([0-9]+)\.([0-9]+)(.*)$/\1/'
Thanks.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/23402
Commit Summary
- c22616e Updated wxwin.m4 macro regex to detect x.x.x[...] versions
File Changes
(1 file)
- M wxwin.m4 (6)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/23402.patch
- https://github.com/wxWidgets/wxWidgets/pull/23402.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
This seems to be the same as #23289. As mentioned there, it's due to some change to wx-config in Gentoo, but I still don't know why did they change it nor where exactly.
But I still suggest submitting your fix to Gentoo developers because it doesn't make sense for wx itself, because our wx-config is never going to output the 4th version component, but they should be willing to take it (if they're not willing to simply revert this change). They also should have no problem with using sed -r, while we can't do this in wx itself because it is not portable and, for example, wouldn't work at all under macOS.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Matthew White
Thank you for the precise answer. I completely missed the #23289 PR.
Gentoo's devs fixed the problem just minutes ago:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=86d51f8fb503db6f6f023efdb1ebca4590404fa7
Simply put, the fix drops the 4th version component from the release string, so it's never printed by the installed wx-config.
I just installed the Gentoo's wxGTK-3.2.2.1 fixed version and xCHM configures and compiles fine now.
I'm closing the PR. Thanks ;)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Matthew White
Closed #23402.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Răzvan Cojocaru
Great! Thanks for researching it. I'm glad it's all sorted out.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.