Correct wxHTML IMG ALIGN=CENTER placement (PR #26669)
Richard Thomson
Capture the current text metrics when parsing image cells and use them to position ALIGN=CENTER images relative to the surrounding text center. Add a parser regression test for the image and adjacent word vertical centers.
Fixes #2976
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26669
Commit Summary
- de239b6 Correct wxHTML IMG ALIGN=CENTER placement
File Changes
(2 files)
- M src/html/m_image.cpp (15)
- M tests/html/htmlparser.cpp (31)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26669.patch
- https://github.com/wxWidgets/wxWidgets/pull/26669.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Richard Thomson
LegalizeAdulthood left a comment (wxWidgets/wxWidgets#26669)The 2 failures appear to be due to ci.yml:169:
apt-add-repository ppa:git-core/ppa
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.