Use wxGridCellEditor::AcceptsTextInput() to enable or disable IME (PR #27206)
VZ
Add a new virtual function and implement it for all grid editors defined in wxWidgets and use it instead of a "probe" checking if IsAcceptedKey() returns true for "a" which was added in a recent eb685ad (Disable IME when the current wxGrid cell doesn't support text input, 2026-09-20).
This avoids problems with custom editors that don't expect to receive "a" in their IsAcceptedKey() and beep when they do.
See #24558.
Fixes #27204.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/27206
Commit Summary
- 4c36ffe Use wxGridCellEditor::AcceptsTextInput() to enable or disable IME
File Changes
(4 files)
- M include/wx/generic/grid.h (6)
- M include/wx/generic/grideditors.h (5)
- M interface/wx/grid.h (19)
- M src/generic/grid.cpp (10)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/27206.patch
- https://github.com/wxWidgets/wxWidgets/pull/27206.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.