Guard wxPreviewCanvas control-bar shortcuts (PR #26905)

11 views
Skip to first unread message

Richard Thomson

unread,
Aug 24, 2026, 4:01:40 PM (3 days ago) Aug 24
to wx-...@googlegroups.com, Subscribed

Avoid assuming that wxPreviewCanvas is parented directly by wxPreviewFrame when handling keyboard and mouse-wheel shortcuts. Look up the preview control bar only after confirming that the preview frame or parent really is a wxPreviewFrame, and skip the event when the canvas is embedded elsewhere.

Fixes #9822


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/26905

Commit Summary

  • 7e40ec4 Guard wxPreviewCanvas control-bar shortcuts

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26905@github.com>

VZ

unread,
Aug 26, 2026, 10:43:27 AM (22 hours ago) Aug 26
to wx-...@googlegroups.com, Subscribed
vadz left a comment (wxWidgets/wxWidgets#26905)

Thanks! I will merge this soon.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26905/c5427003957@github.com>

VZ

unread,
Aug 26, 2026, 1:29:22 PM (19 hours ago) Aug 26
to wx-...@googlegroups.com, Subscribed

Closed #26905 via 68ef146.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26905/issue_event/30058102285@github.com>

Reply all
Reply to author
Forward
0 new messages