Upgrade downloading WebView2 (Edge) from 1.0.1722.45 to 1.0.3485.44 (PR #25817)

24 views
Skip to first unread message

Blake-Madden

unread,
Sep 19, 2025, 7:48:03 AM (6 days ago) Sep 19
to wx-...@googlegroups.com, Subscribed

Document how to update this in the build script
Closes #25815
Part of fix for ##25816


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/25817

Commit Summary

  • bba7c2f Upgrade downloading WebView2 (Edge) from 1.0.1722.45 to 1.0.3485.44

File Changes

(2 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25817@github.com>

Maarten

unread,
Sep 19, 2025, 3:20:47 PM (6 days ago) Sep 19
to wx-...@googlegroups.com, Subscribed

@MaartenBent commented on this pull request.


In include/wx/msw/private/webview_edge.h:

> @@ -20,7 +20,7 @@
 #include <WebView2.h>
 
 #ifndef __ICoreWebView2Settings3_INTERFACE_DEFINED__
-    #error "WebView2 SDK version 1.0.1722.45 or newer is required"
+    #error "WebView2 SDK version 1.0.3485.44 or newer is required"

I don't think we need to update this error message. The code still compiles when using WebView2 1.0.1722.45. Only when we starting using newer interfaces we need to update the minimum version.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25817/review/3244959950@github.com>

Blake-Madden

unread,
Sep 19, 2025, 5:02:09 PM (6 days ago) Sep 19
to wx-...@googlegroups.com, Push

@Blake-Madden pushed 1 commit.


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25817/before/bba7c2fe79a8fcf377b55e985354bacbc02d9fac/after/02a44df391bbefa03029f3bd380f12601fbb1790@github.com>

Blake-Madden

unread,
Sep 19, 2025, 5:02:58 PM (6 days ago) Sep 19
to wx-...@googlegroups.com, Subscribed

@Blake-Madden commented on this pull request.


In include/wx/msw/private/webview_edge.h:

> @@ -20,7 +20,7 @@
 #include <WebView2.h>
 
 #ifndef __ICoreWebView2Settings3_INTERFACE_DEFINED__
-    #error "WebView2 SDK version 1.0.1722.45 or newer is required"
+    #error "WebView2 SDK version 1.0.3485.44 or newer is required"

Fair enough, I rolled that message back.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25817/review/3247097044@github.com>

VZ

unread,
Sep 23, 2025, 9:10:50 AM (2 days ago) Sep 23
to wx-...@googlegroups.com, Subscribed

Closed #25817 via 8c68c1a.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25817/issue_event/19866312477@github.com>

Reply all
Reply to author
Forward
0 new messages