Add support for reserving X number of images for image list (include ribbon's image list) (PR #25868)
Blake-Madden
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25868
Commit Summary
- 5ff6bc8 Generic image list: use initalCount argument to reserve elements
- 8337aa6 Add support for reserving X number of images for ribbon's image list
File Changes
(4 files)
- M include/wx/ribbon/bar.h (2)
- M interface/wx/ribbon/bar.h (5)
- M src/generic/imaglist.cpp (4)
- M src/ribbon/bar.cpp (4)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25868.patch
- https://github.com/wxWidgets/wxWidgets/pull/25868.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- 58b05f7 Document other parameter and return type.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
As I said, I'd rather stop using wxImageList completely, but as long as don't have any alternative here, I don't see any problem with adding this.
> @@ -480,9 +480,14 @@ class wxRibbonBar : public wxRibbonControl
Return the image list containing images of the given size, creating it
if necessary.
+ @param size The size of the images going into this image list.
+ @param initialCount The initial number of images to reserve for the
+ image list.
⬇️ Suggested change
- image list. + image list (this parameter is available since wxWidgets 3.3.2).
> @since 3.1.4
*/
- wxImageList* GetButtonImageList(wxSize size);
+ wxImageList* GetButtonImageList(wxSize size, int initialCount);
⬇️ Suggested change
- wxImageList* GetButtonImageList(wxSize size, int initialCount); + wxImageList* GetButtonImageList(wxSize size, int initialCount = 1);
> {
// Prevent from storing negative dimensions
m_size = wxSize(wxMax(width, 0), wxMax(height, 0));
m_useMask = mask;
+ m_images.reserve(initialCount);
Maybe
⬇️ Suggested change- m_images.reserve(initialCount); + if ( initialCount > 1 ) + m_images.reserve(initialCount);
to avoid a useless (I believe) call by default?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- c71bf73 Update interface/wx/ribbon/bar.h
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- d62f955 Update interface/wx/ribbon/bar.h
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- cb8b764 Update src/generic/imaglist.cpp
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.