MSW: Minimize dark mode border flicker (PR #26631)
Steve Cornett
These changes address flickering borders in dark mode, primarily with the non-rich wxTextCtrl. The wxListBox border also flickers, but is less noticeable. See #26630.
The flicker occurs when the mouse moves over the border or scroll bar. The problem might not be reproducible on all systems, perhaps depending on graphics drivers. The cause is that these controls generate many unnecessary WM_NCPAINT messages. In our WM_NCPAINT handler, the the light mode border gets drawn and the dark mode border over that.
The solution is to use the DarkMode_DarkTheme theme when available. With this theme, these controls draw a good dark border for most border styles, including the default style. In this case, we do not draw over the border. A new member is introduced to the MSWDarkModeSupport struct to indicate whether we need the custom border drawing.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26631
Commit Summary
- a8cc3b9 Use DarkMode_DarkTheme and avoid redrawing border
File Changes
(5 files)
- M include/wx/msw/textctrl.h (2)
- M include/wx/msw/window.h (6)
- M src/msw/listbox.cpp (6)
- M src/msw/textctrl.cpp (20)
- M src/msw/window.cpp (7)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26631.patch
- https://github.com/wxWidgets/wxWidgets/pull/26631.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Steve Cornett
@stevecor pushed 1 commit.
- cacbba5 Convert border styles that flicker to wxBORDER_SIMPLE
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Steve Cornett
stevecor left a comment (wxWidgets/wxWidgets#26631)PR #26635 appears to be a better solution.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Steve Cornett
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.