Doc/View MDI missing the "Window" menu on GTK (Issue #25761)
oneeyeman1
oneeyeman1 created an issue (wxWidgets/wxWidgets#25761)Description
Summary says it all
However, IMHO I don't think it should be called "Window" on GTK. On this platform it is a Notebook-like interface, and so it probably needs to be called "Document". Also
OTOH, to stay consistent with other platforms it could be called "Window".
Patch or snippet allowing to reproduce the problem:
Build the library.
Build the docview sample
Run the sample and select the Drawing view.
Observe that there is no "Window" menu.
Stack trace:
N/A
Platform and version information
- wxWidgets version you use: 3.3.1
- wxWidgets port you use: wxGTK
- OS and its version: Gentoo Linux
- GTK version: 3.24.41
- Which GDK backend is used: X11
- Desktop environment : GNOME modern, non-classic
- Current theme: Defaut (Adwaita)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25761)I can indeed see this and I think it's a regression as I'm almost sure this did work before.
Do you know what was the last version in which it worked?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
oneeyeman1
oneeyeman1 left a comment (wxWidgets/wxWidgets#25761)@vadz ,
I don't think it ever worked.
You probably remember our old discussion about it being missing and whether or not it should be called "Document" or "Window"
Thank you
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25761)All right, it never worked in GTK version because support for it is only implemented in the generic version, not GTK one. This being said, I have no idea what are the advantages of the GTK version and why didn't we switch generic version of MDI under GTK too (historically GTK version predates generic, but generic seems to be more functional currently).
So maybe all we need to do is to actually remove GTK version and use generic there too. But if not, we'd have to copy support for "Window" menu from generic to GTK.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
oneeyeman1
oneeyeman1 left a comment (wxWidgets/wxWidgets#25761)@vadz,
Is there a way to check how how it will look like? Any option in the doc view sample?
Thank you.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25761)You need to predefine wxUSE_GENERIC_MDI_AS_NATIVE when building the library (and also when using it). It may be simpler to just change wx/mdi.h to always define it as 1 for testing.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
oneeyeman1
oneeyeman1 left a comment (wxWidgets/wxWidgets#25761)@vadz,
I’ll check configure script for an option. And there is a define in the sample…
Thx.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.