Install the scrolled window's sizer after reparenting its controls (PR #26916)
Gunter Königsman
When porting wxWidgets to GTK4 Claude reckons to have found 6 bugs in wxWidgets that hinder samples, example applications or tests from working. To me as a casual outsider the patches look like actually resolving existing bugs. I currently push them as separate pull requests so they can be individually reviewed.
wxWizard::DoLayoutAdaptation() moves a page's controls into a scrolled window, and did it in this order:
page->SetSizer(newSizer, false);
scrolledWindow->SetSizer(oldSizer);
wxStandardDialogLayoutAdapter::DoReparentControls(page, scrolledWindow);
so the scrolled window was given a sizer managing controls that were, at that moment, still children of the page. The controls only became its children on the next line.
Reparent first and set the sizer afterwards, so that the sizer is installed on a window that already owns everything it lays out.
(cherry picked from commit dc4d5c6)
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26916
Commit Summary
- c645bf4 Install the scrolled window's sizer after reparenting its controls
File Changes
(1 file)
- M src/generic/wizard.cpp (4)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26916.patch
- https://github.com/wxWidgets/wxWidgets/pull/26916.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26916)I actually struggle to understand what difference does this make, but I agree that the new version looks more logical, so I'll merge this too, thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.