Fix positioning images in generic wx{List,Tree}Ctrl in high DPI (PR #26397)
VZ
The implementation of GetImageLogicalSize() overload taking the image index returned correct answer for this individual image, but was wrong when used in the control with multiple images with different logical sizes. This resulted in the actual bitmap being drawn, as returned by GetImageBitmapFor(), being of different size than the size returned by this function, as GetImageBitmapFor() uses the best ("consensus") size for all images, which is also returned by GetImageLogicalSize() overload not taking the image.
Solve this by simply getting rid of the overload taking the image and replacing all existing calls to it with the calls to the other overload. This is backwards-incompatible, but this function was only added in 3.3 and removing it is a lesser evil than either leaving a function which can only be misused, or keeping the unused image index parameter which would be confusing.
Closes #26391.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26397
Commit Summary
- c45b10f Fix positioning images in generic wx{List,Tree}Ctrl in high DPI
File Changes
(6 files)
- M docs/changes.txt (3)
- M include/wx/generic/private/listctrl.h (2)
- M include/wx/withimages.h (24)
- M samples/listctrl/listtest.cpp (25)
- M src/generic/listctrl.cpp (30)
- M src/generic/treectlg.cpp (32)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26397.patch
- https://github.com/wxWidgets/wxWidgets/pull/26397.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- c2a8bad Fix positioning images in generic wx{List,Tree}Ctrl in high DPI
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.