Apply wx coding standards to ribbon source (PR #26567)
Blake-Madden
Name variables correctly (camel case, members prefixed with m_).
Fix spacing and other formatting.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26567
Commit Summary
- aecf82d Apply wx coding standards to ribbon source
File Changes
(20 files)
- M include/wx/ribbon/art.h (458)
- M include/wx/ribbon/art_internal.h (74)
- M include/wx/ribbon/bar.h (80)
- M include/wx/ribbon/buttonbar.h (124)
- M include/wx/ribbon/control.h (16)
- M include/wx/ribbon/gallery.h (54)
- M include/wx/ribbon/page.h (30)
- M include/wx/ribbon/panel.h (44)
- M include/wx/ribbon/toolbar.h (106)
- M src/ribbon/art_aui.cpp (1111)
- M src/ribbon/art_internal.cpp (204)
- M src/ribbon/art_msw.cpp (2812)
- M src/ribbon/art_msw_flat.cpp (662)
- M src/ribbon/bar.cpp (884)
- M src/ribbon/buttonbar.cpp (948)
- M src/ribbon/control.cpp (26)
- M src/ribbon/gallery.cpp (537)
- M src/ribbon/page.cpp (658)
- M src/ribbon/panel.cpp (515)
- M src/ribbon/toolbar.cpp (720)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26567.patch
- https://github.com/wxWidgets/wxWidgets/pull/26567.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
I'm always uncomfortable applying changes like this because there is always a risk of breaking something without any really good reason to do it.
For example, I've randomly checked if anybody uses m_primary_scheme_colour and it seems like CodeLite does. So I think we need to leave the protected variables alone...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.