wxXmlDocument encoding (Issue #26621)
BazaarAcc32
BazaarAcc32 created an issue (wxWidgets/wxWidgets#26621)I'm interested in the wxXmlDocument::Load method, which takes a wxInputStream as a parameter. The documentation provides the following signature:
virtual bool Load (wxInputStream &stream, const wxString &encoding="UTF-8", int flags=wxXMLDOC_NONE)
"'wxXmlDocument::Load': Remove encoding parameter from the call" -- in MSVC Compiler, Visual Studio 2022
for this code
doc.Load(stream, "UTF-8", wxXMLDOC_NONE)Apparently, the method signature has been updated and now specifying the encoding is no longer required. So my question is, if the encoding can't be specified anymore, what encoding does wxXmlDocument::Load expect to receive?
Please answer my question & update docs if needed.
Thanks in advance
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26621)It uses the encoding as specified in the xml document. The default encoding of xml documents is utf-8.
The encoding parameter in the constructor and Load() were never used, see #24167
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26621)Thanks for answering this. I don't think there is anything to do here, the deprecation warning (not an error BTW) is already correct and the extra parameter just needs to be removed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26621)The documentation was also updated, there is different documentation for wx3.2 and wx3.3.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
BazaarAcc32
BazaarAcc32 left a comment (wxWidgets/wxWidgets#26621)You're right, but the documentation still doesn't say anything about wxInputStream encoding
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.