Use UTF-8 with MSVC and for string literals (PR #25549)
VZ
Replaces #25373.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25549
Commit Summary
- 1c79dbc Always interpret sources used in MSVS projects as UTF-8
- d6dba57 Always use /utf-8 with MSVS when using CMake too
- ee35859 Replace hex and octal escapes with literal UTF-8 characters
File Changes
(17 files)
- M build/cmake/functions.cmake (1)
- M build/msw/wx_setup.props (1)
- M src/common/datetimefmt.cpp (4)
- M src/common/utilscmn.cpp (6)
- M src/generic/aboutdlgg.cpp (2)
- M src/qt/renderer.cpp (3)
- M tests/exec/exec.cpp (2)
- M tests/file/filefn.cpp (4)
- M tests/mbconv/convautotest.cpp (6)
- M tests/streams/datastreamtest.cpp (2)
- M tests/strings/crt.cpp (6)
- M tests/strings/stdstrings.cpp (5)
- M tests/strings/strings.cpp (8)
- M tests/strings/unicode.cpp (8)
- M tests/strings/vsnprintf.cpp (8)
- M tests/textfile/textfiletest.cpp (19)
- M tests/uris/uris.cpp (17)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25549.patch
- https://github.com/wxWidgets/wxWidgets/pull/25549.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#25549)AppVeyors Visual Studio 2015 seems to fail on tests that are missing wxString::FromUTF8().
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Kumazuma
Kumazuma left a comment (wxWidgets/wxWidgets#25549)It looks good to me.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- b672131 Replace hex and octal escapes with literal UTF-8 characters
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25549)AppVeyors Visual Studio 2015 seems to fail on tests that are missing
wxString::FromUTF8().
It looks like it doesn't handle Unicode characters in the wide strings, I've tried to work around it just for it. But maybe we should just drop support for it, anecdotally it seems that some people still use MSVS 2017 but I don't know anybody still using 2015...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Merged #25549 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.