osx: added `#if wxUSE_TOGGLEBTN` around NSToggleButton (PR #26797)

9 views
Skip to first unread message

Mongilyov Andrey

unread,
Aug 7, 2026, 8:20:04 AM (3 days ago) Aug 7
to wx-...@googlegroups.com, Subscribed

Hi!

I use wxWidgets 3.3.0 on macOS with set(wxUSE_TOGGLEBTN OFF). When I tried to update to 3.3.3, I got a compile error:

build_wxw333/wxWidgets/src/osx/cocoa/button.mm:145:17: error: use of undeclared identifier 'toggleButtonType'
  145 |                 toggleButtonType = NSToggleButton;

Tried to do a simple fix. Since bool isToggleButton is under #if wxUSE_TOGGLEBTN then its usage should be under the same condition. Code compiled successfully.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/26797

Commit Summary

  • 5461e9f osx: added #ifdef arround NSToggleButton

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26797@github.com>

VZ

unread,
Aug 7, 2026, 8:29:22 AM (3 days ago) Aug 7
to wx-...@googlegroups.com, Subscribed
vadz left a comment (wxWidgets/wxWidgets#26797)

Thanks, will merge soon.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26797/c5217059791@github.com>

VZ

unread,
Aug 9, 2026, 1:37:15 PM (13 hours ago) Aug 9
to wx-...@googlegroups.com, Subscribed

Closed #26797 via 98710f8.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26797/issue_event/29188510100@github.com>

Reply all
Reply to author
Forward
0 new messages