add a wxGTK on macOS build action (PR #25924)
Stefan Csomor
right now only manually triggered
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25924
Commit Summary
- fe75b07 add a wxGTK on macOS build
File Changes
(1 file)
- A .github/workflows/ci_mac_gtk.yml (190)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25924.patch
- https://github.com/wxWidgets/wxWidgets/pull/25924.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz approved this pull request.
Looks good, thanks!
In .github/workflows/ci_mac_gtk.yml:
> + + - name: Testing GUI + if: matrix.skip_testing != true + working-directory: tests + run: | + # We currently need to disable container overflow detection as we get + # what seems to be a false positive in BitmapComboBoxTestCase triggered + # by creating a new string from std::allocator<wxString>::construct() + # used by std::vector<>::insert(). + export ASAN_OPTIONS='fast_unwind_on_malloc=0 detect_container_overflow=0' + # Exclude tests that are currently known to fail + wx_tests_selection='~[.] ~[valnum] ~wxPersistTLW ~wxPersistDVC ~wxTopLevel::Show ~wxFont::Weight ~wxFont::NativeFontInfo ~WebView ~RadioButton::Single ~RadioButton::Focus ~wxHtmlPrintout::Pagination ~wxTextCtrl::GetBestSize ~TextCtrlTestCase ~wxExecute::RedirectUTF8 ~Ellipsization::NormalCase ~SpinCtrl::* ~SpinCtrlDouble::* ~NotebookTestCase ~SettingsTestCase ~Window::Show ~ModalDialogsTestCase ~Button::Click ~Button::Disabled ~wxDVC::GetItemRect ~wxDVC::AppendTextColumn ~Grid::KeyboardSelection ~Grid::CellClick ~Grid::ReorderedColumnsCellClick ~Grid::CellSelect ~wxStyledTextCtrl::AutoComp ~EvtLoopTestCase ~EventPropagationTestCase ~wxTreeCtrl::ItemClick ~wxTreeCtrl::LabelEdit ~wxTreeCtrl::KeyDown ~wxTreeCtrl::CollapseExpandEvents ~wxTreeCtrl::SelectionChange ~wxTreeCtrl::SelectItemMultiInteractive ~wxTreeCtrl::Menu ~wxTreeCtrl::KeyNavigation' + ./test_gui.app/Contents/MacOS/test_gui $wx_tests_selection + + - name: Building samples + if: matrix.skip_testing != true && matrix.skip_samples != true
Probably should be
⬇️ Suggested change- if: matrix.skip_testing != true && matrix.skip_samples != true + if: matrix.skip_samples != true
In .github/workflows/ci_mac_gtk.yml:
> + # We currently need to disable container overflow detection as we get + # what seems to be a false positive in BitmapComboBoxTestCase triggered + # by creating a new string from std::allocator<wxString>::construct() + # used by std::vector<>::insert(). + export ASAN_OPTIONS='fast_unwind_on_malloc=0 detect_container_overflow=0' + # Exclude tests that are currently known to fail + wx_tests_selection='~[.] ~[valnum] ~wxPersistTLW ~wxPersistDVC ~wxTopLevel::Show ~wxFont::Weight ~wxFont::NativeFontInfo ~WebView ~RadioButton::Single ~RadioButton::Focus ~wxHtmlPrintout::Pagination ~wxTextCtrl::GetBestSize ~TextCtrlTestCase ~wxExecute::RedirectUTF8 ~Ellipsization::NormalCase ~SpinCtrl::* ~SpinCtrlDouble::* ~NotebookTestCase ~SettingsTestCase ~Window::Show ~ModalDialogsTestCase ~Button::Click ~Button::Disabled ~wxDVC::GetItemRect ~wxDVC::AppendTextColumn ~Grid::KeyboardSelection ~Grid::CellClick ~Grid::ReorderedColumnsCellClick ~Grid::CellSelect ~wxStyledTextCtrl::AutoComp ~EvtLoopTestCase ~EventPropagationTestCase ~wxTreeCtrl::ItemClick ~wxTreeCtrl::LabelEdit ~wxTreeCtrl::KeyDown ~wxTreeCtrl::CollapseExpandEvents ~wxTreeCtrl::SelectionChange ~wxTreeCtrl::SelectItemMultiInteractive ~wxTreeCtrl::Menu ~wxTreeCtrl::KeyNavigation' + ./test_gui.app/Contents/MacOS/test_gui $wx_tests_selection + + - name: Building samples + if: matrix.skip_testing != true && matrix.skip_samples != true + run: | + make -k $wxBUILD_ARGS "CXXFLAGS=$wxMAKEFILE_CXXFLAGS" "LDFLAGS=$wxMAKEFILE_LDFLAGS" samples + + - name: Installing + if: matrix.skip_testing != true
I think we should always test installation and compiling minimal using the installed version, this doesn't take much time and really should work.
I.e. I'd remove this if: and the one below.
In .github/workflows/ci_mac_gtk.yml:
> + run: | + . ../build/tools/httpbin.sh + httpbin_launch + export ASAN_OPTIONS=fast_unwind_on_malloc=0 + # Explicitly use bash because /bin/sh doesn't have pipefail option + /bin/bash -o pipefail -c './test 2>&1 | tee test.out' || rc=$? + if [ -n "$rc" ]; then + httpbin_show_log + exit $rc + fi + + - name: Testing GUI + if: matrix.skip_testing != true + working-directory: tests + run: | + # We currently need to disable container overflow detection as we get
I'm not sure if all this is relevant for this build...
In .github/workflows/ci_mac_gtk.yml:
> + configure_flags: --disable-uiactionsim --with-cxx=11 --without-liblzma --enable-debug --disable-sys-libs --with-gtk=3 --with-opengl=no --enable-detect_sm=no + skip_samples: true + skip_testing: true + allow_warnings: true + + steps: + - name: Checkout + uses: actions/checkout@v4 + with: + submodules: recursive + + - name: Set up Homebrew + id: set-up-homebrew + uses: Homebrew/actions/setup-homebrew@main + + - name: Install gtk+3
This is very nitpicky but they don't use "+" in their name any more, i.e.
⬇️ Suggested change- - name: Install gtk+3 + - name: Install GTK 3
In .github/workflows/ci_mac_gtk.yml:
> + defaults:
+ run:
+ shell: /usr/bin/arch -arch ${{ matrix.arch }} /bin/bash --noprofile --norc -eo pipefail {0}
+
+ runs-on: ${{ matrix.runner }}
+
+ name: ${{ matrix.name }}
+
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - name: wxGTK on macOS
+ runner: macos-latest
+ arch: arm64
+ configure_flags: --disable-uiactionsim --with-cxx=11 --without-liblzma --enable-debug --disable-sys-libs --with-gtk=3 --with-opengl=no --enable-detect_sm=no
Just out of curiosity, is OpenGL broken in this build?
Also, not sure why we need to disable LZMA, it will just be auto-disabled if support is not found?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- 6b48059 Apply suggestions from code review
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- 944c1a0 as suggested, always install and make minmal sample
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor commented on this pull request.
In .github/workflows/ci_mac_gtk.yml:
> + run: | + . ../build/tools/httpbin.sh + httpbin_launch + export ASAN_OPTIONS=fast_unwind_on_malloc=0 + # Explicitly use bash because /bin/sh doesn't have pipefail option + /bin/bash -o pipefail -c './test 2>&1 | tee test.out' || rc=$? + if [ -n "$rc" ]; then + httpbin_show_log + exit $rc + fi + + - name: Testing GUI + if: matrix.skip_testing != true + working-directory: tests + run: | + # We currently need to disable container overflow detection as we get
I thought perhaps more functionality might be used once, so I've copied the steps from our other command line mac builds, but of course we could remove things
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
> + defaults:
+ run:
+ shell: /usr/bin/arch -arch ${{ matrix.arch }} /bin/bash --noprofile --norc -eo pipefail {0}
+
+ runs-on: ${{ matrix.runner }}
+
+ name: ${{ matrix.name }}
+
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - name: wxGTK on macOS
+ runner: macos-latest
+ arch: arm64
+ configure_flags: --disable-uiactionsim --with-cxx=11 --without-liblzma --enable-debug --disable-sys-libs --with-gtk=3 --with-opengl=no --enable-detect_sm=no
the LZMA was a left over from an earlier configure line of mine, I'll remove that. With OpenGL I ran into a build problem, apparently the homebrew version of gtk+ uses Quartz and not X11 anymore.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
> + # We currently need to disable container overflow detection as we get + # what seems to be a false positive in BitmapComboBoxTestCase triggered + # by creating a new string from std::allocator<wxString>::construct() + # used by std::vector<>::insert(). + export ASAN_OPTIONS='fast_unwind_on_malloc=0 detect_container_overflow=0' + # Exclude tests that are currently known to fail + wx_tests_selection='~[.] ~[valnum] ~wxPersistTLW ~wxPersistDVC ~wxTopLevel::Show ~wxFont::Weight ~wxFont::NativeFontInfo ~WebView ~RadioButton::Single ~RadioButton::Focus ~wxHtmlPrintout::Pagination ~wxTextCtrl::GetBestSize ~TextCtrlTestCase ~wxExecute::RedirectUTF8 ~Ellipsization::NormalCase ~SpinCtrl::* ~SpinCtrlDouble::* ~NotebookTestCase ~SettingsTestCase ~Window::Show ~ModalDialogsTestCase ~Button::Click ~Button::Disabled ~wxDVC::GetItemRect ~wxDVC::AppendTextColumn ~Grid::KeyboardSelection ~Grid::CellClick ~Grid::ReorderedColumnsCellClick ~Grid::CellSelect ~wxStyledTextCtrl::AutoComp ~EvtLoopTestCase ~EventPropagationTestCase ~wxTreeCtrl::ItemClick ~wxTreeCtrl::LabelEdit ~wxTreeCtrl::KeyDown ~wxTreeCtrl::CollapseExpandEvents ~wxTreeCtrl::SelectionChange ~wxTreeCtrl::SelectItemMultiInteractive ~wxTreeCtrl::Menu ~wxTreeCtrl::KeyNavigation' + ./test_gui.app/Contents/MacOS/test_gui $wx_tests_selection + + - name: Building samples + if: matrix.skip_testing != true && matrix.skip_samples != true + run: | + make -k $wxBUILD_ARGS "CXXFLAGS=$wxMAKEFILE_CXXFLAGS" "LDFLAGS=$wxMAKEFILE_LDFLAGS" samples + + - name: Installing + if: matrix.skip_testing != true
Thanks, did that
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- d03680b Removed unnecessary LZMA configure flag
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
Merged #25924 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.