wxGridBagSizer item clipping when vgap/hgap are different and some items span multiple rows/cols (Issue #24550)
dsa-t
Description
If:
- vgap and hgap are different in wxGridBagSizer
- It has items spanning multiple rows (buttons in the example)
then row heights are not calculated correctly, clipping the buttons:
image.png (view on web)
If the hgap is set to 0, equal to vgap, it looks normal:
image.png (view on web)
wxFormBuilder 4.1.0 project: manager_icons.fbp.txt
Merged cpp+header file: noname.cpp.txt
Looks like these lines are wrong:
Platform and version information
- wxWidgets version you use: 3.2.4
- wxWidgets port you use: wxMSW
- OS and its version: Windows 11
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
So is the problem fixed by exchanging the H and V gaps (I don't know this code at all but it would seem to be more logical to subtract vertical gap from the height and horizontal gap from the width rather than vice versa)?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
dsa-t
Yes, it does seem to fix the issue:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Thanks for testing, will push the fix soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Closed #24550 as completed via b4c3bcd.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.