Re: [wx-dev] regex build

[ABX]

Ryan Norton <wxpro...@comcast.net>:
> > Well, that changes it, these are all legitimate warnings. I'll revert
> > the change. Ryan, will you please fix this?
> I'll look into it.

Current status :-)

gcc:

gcc -c -o gcc_mswunivu\wxregex_regexec.o -O2 -DHAVE_W32API_H -I..\..\include
-I..\..\lib\gcc_lib\mswunivu -D_UNICODE ../../src/regex/regexec.c
In file included from ../../src/regex/regexec.c:1079:
../../src/regex/rege_dfa.c:699:2: warning: no newline at end of file

bcc:

bcc32 -q -c -P- -obcc_mswud\wxregex_regcomp.obj
-Ih:\BORLAND\BCC55\include -v -Od -tWM -I..\..\include
-I..\..\lib\bcc_lib\mswud -D_UNICODE -w-8004 -w-8012 -w-8057 -w-8066 -a8 -g0
..\..\src\regex\regcomp.c
..\..\src\regex\regcomp.c:
Warning W8070 ..\..\src\regex\regc_lex.c 874: Function should return a value
in function lexescape
Warning W8070 ..\..\src\regex\regc_lex.c 1077: Function should return a value
in function brenext
Warning W8008 ..\..\src\regex\regc_color.c 96: Condition is always true in
function freecm
bcc32 -q -c -P- -obcc_mswud\wxregex_regexec.obj
-Ih:\BORLAND\BCC55\include -v -Od -tWM -I..\..\include
-I..\..\lib\bcc_lib\mswud -D_UNICODE -w-8004 -w-8012 -w-8057 -w-8066 -a8 -g0
..\..\src\regex\regexec.c
..\..\src\regex\regexec.c:
Warning W8070 ..\..\src\regex\regexec.c 594: Function should return a value in
function dissect
Warning W8070 ..\..\src\regex\regexec.c 757: Function should return a value in
function cdissect

ABX

[Vaclav Slavik]

Dimitri wrote:
> I thought the preference was to lower warnings levels instead of
> fixing 3rd party source (depending on type of warning ofcourse).

Generally, yes, and it's true for 4 of these warnings. But majority of
them warnings is in Ryan's modifications.

Vaclav

--
PGP key: 0x465264C9, available from http://pgp.mit.edu/

[Dimitri]

At 11:21 19/01/2004, ABX wrote:
>Vaclav Slavik <vaclav...@matfyz.cz>:
> > > I'm asking because MinGW reports
> > > warnings for regex as well.
> >
> > GCC usually warns for a good reason (unlike BCC)...
>
>here is the output I saved 16.01.2004

[Borland and MinGW warnings]

>No warnings under Open Watcom and VC.

? Even build/msw/wx_wxregex.dsp (which has warn level set to 1) gives me 10
warnings with MSVC6:

src\regex\regcomp.c(1696) : warning C4761: integral size mismatch in
argument; conversion supplied
src\regex\regcomp.c(1697) : " "
src\regex\regcomp.c(1699) : " "
src\regex\regcomp.c(1700) : " "
src\regex\regc_locale.c(486) : " "
src\regex\regc_locale.c(486) : " "
src\regex\regc_locale.c(504) : " "
src\regex\regc_locale.c(507) : " "
src\regex\regc_locale.c(510) : " "
src\regex\regc_locale.c(556) : " "

And src/regex/regex.dsp (warn level 4) gives these additional 18 warnings:

src\regex\regcomp.c(953) : warning C4018: '<' : signed/unsigned mismatch
src\regex\regc_color.c(315) : warning C4018: '<' : signed/unsigned mismatch
src\regex\regc_color.c(327) : warning C4018: '<' : signed/unsigned mismatch
src\regex\regc_color.c(431) : warning C4305: '+=' : truncation from 'const
long ' to 'char '
src\regex\regc_nfa.c(230) : warning C4100: 'nfa' : unreferenced formal
parameter
src\regex\regc_nfa.c(1343) : warning C4100: 'f' : unreferenced formal parameter
src\regex\regc_nfa.c(1342) : warning C4100: 'nfa' : unreferenced formal
parameter
src\regex\regc_locale.c(398) : warning C4100: 'v' : unreferenced formal
parameter
src\regex\regc_locale.c(410) : warning C4100: 'v' : unreferenced formal
parameter
src\regex\regc_locale.c(419) : warning C4100: 'v' : unreferenced formal
parameter
src\regex\regc_locale.c(670) : warning C4305: 'function' : truncation from
'const int ' to 'char '
regerror.c
src\regex\regc_color.c(511) : warning C4701: local variable 'b' may be used
without having been initialized
src\regex\regc_color.c(511) : warning C4701: local variable 'lastt' may be
used without having been initialized
src\regex\regerror.c(67) : warning C4100: 'preg' : unreferenced formal
parameter
regexec.c
src\regex\regexec.c(175) : warning C4013: 'wx_strlen' undefined; assuming
extern returning int
src\regex\regexec.c(409) : warning C4100: 'cm' : unreferenced formal parameter
src\regex\regexec.c(408) : warning C4100: 'cnfa' : unreferenced formal
parameter
regfree.c
src\regex\rege_dfa.c(617) : warning C4701: local variable 'lastap' may be
used without having been initialized

I thought the preference was to lower warnings levels instead of fixing 3rd
party source (depending on type of warning ofcourse).

Regards,
Dimitri

[Ryan Norton]

>> I thought the preference was to lower warnings levels instead of
>> fixing 3rd party source (depending on type of warning ofcourse).
>Generally, yes, and it's true for 4 of these warnings. But majority of
>them warnings is in Ryan's modifications.

Well, you're partially correct at least.

Those modifications were part of postgresql, and from what I gather about
the
warnings they could be safely ignored (they were all the same one :)).

Anyway, I got rid of them.

Ryan