wxSearchCtrl not rendered correctly in wxQt (Issue #23170)

21 views
Skip to first unread message

AliKet

unread,
Jan 23, 2023, 8:22:15 AM1/23/23
to wx-...@googlegroups.com, Subscribed

Description

Due to this commit f2106dc (which can be safely reverted since wxGTK has its own implementation now anyway) the text control colour is black as can be seen in the image below:
searchctrl_bad

Expected:
searchctrl

Platform and version information

  • wxWidgets version you use: latest
  • wxWidgets port you use: wxQt (Qt 5.5)
  • OS and its version: Ubuntu 18.04


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/23170@github.com>

VZ

unread,
Jan 23, 2023, 8:29:23 AM1/23/23
to wx-...@googlegroups.com, Subscribed

I agree that the other change doesn't seem necessary any more, but I also think that wxQt is wrong here as setting an invalid colour shouldn't set the background to black, but rather reset the background colour to the default value, i.e. undo the effect of any previous SetBackgroundColour() calls. Is it possible to implement this semantics in wxQt?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/23170/1400341037@github.com>

dsa-t

unread,
Feb 13, 2024, 1:40:24 PM2/13/24
to wx-...@googlegroups.com, Subscribed

Looks like this currently:

Screenshot_2024-02-13_21-09-28.png (view on web)

A check for invalid color can be added in wxQtDCImpl::SetBackground.
Or in wxWindowQt::SetBackgroundColour

But in order to get white color on the full area

But also the order in wxSearchCtrl::Create has to be reversed:

m_text->SetBackgroundColour(wxColour());
SetBackgroundColour( m_text->GetBackgroundColour() );


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/23170/1942168898@github.com>

VZ

unread,
Feb 13, 2024, 4:10:15 PM2/13/24
to wx-...@googlegroups.com, Subscribed

Closed #23170 as completed via 47b011c.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issue/23170/issue_event/11794007865@github.com>

Reply all
Reply to author
Forward
0 new messages