[wx-dev] Re: #9046: wxThread::OnDelete() and wxThread::OnKill() to add
wxTrac
#9046: wxThread::OnDelete() and wxThread::OnKill() to add
--------------------------+-------------------------------------------------
Reporter: magneticore | Owner:
Type: build error | Status: reopened
Priority: low | Milestone:
Component: base | Version:
Resolution: | Keywords: thread
Blockedby: | Patch: 1
Blocking: |
--------------------------+-------------------------------------------------
Changes (by neis):
* cc: neis (removed)
* status: closed => reopened
* type: => build error
--
Ticket URL: <http://trac.wxwidgets.org/ticket/9046#comment:9>
wxTrac
#9046: wxThread::OnDelete() and wxThread::OnKill() to add
--------------------------+-------------------------------------------------
Reporter: magneticore | Owner:
Type: build error | Status: reopened
Priority: low | Milestone:
Component: base | Version:
Resolution: | Keywords: thread
Blockedby: | Patch: 1
Blocking: |
--------------------------+-------------------------------------------------
Changes (by Peter Most):
* cc: Peter...@gmx.de (added)
--
Ticket URL: <http://trac.wxwidgets.org/ticket/9046#comment:10>
wxTrac
#9046: wxThread::OnDelete() and wxThread::OnKill() to add
--------------------------+-------------------------------------------------
Reporter: magneticore | Owner:
Type: enhancement | Status: reopened
Priority: low | Milestone:
Component: base | Version:
Resolution: | Keywords: thread
Blockedby: | Patch: 1
Blocking: |
--------------------------+-------------------------------------------------
Changes (by vadz):
* cc: vadz (removed)
* type: build error => enhancement
--
Ticket URL: <http://trac.wxwidgets.org/ticket/9046#comment:11>
wxTrac
#9046: wxThread::OnDelete() and wxThread::OnKill() to add
--------------------------+-------------------------------------------------
Reporter: magneticore | Owner:
Type: enhancement | Status: reopened
Priority: low | Milestone:
Component: base | Version:
Resolution: | Keywords: thread
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------
Changes (by vadz):
* patch: 1 => 0
Comment:
I'm resetting the patch checkbox because there is currently no applicable
patch here. The attached one lacks:
1. Documentation (interface/wx/thread.h in svn trunk) which is even more
important for this patch than usual as it's very easy to misunderstand
what these functions do and in which context they're called, even the
patch submitted himself wrote wrong comments for them!
2. Implementation for pthreads (src/unix/threadpsx.cpp) and in this case
we can't add it for one platform only as silently never calling these
functions on other platforms is not acceptable.
If these points could be addressed I guess the patch could be applied,
even though I'm still personally rather sceptical about the need for it.
--
Ticket URL: <http://trac.wxwidgets.org/ticket/9046#comment:12>
wxTrac
#9046: wxThread::OnDelete() and wxThread::OnKill() to add
--------------------------+-------------------------------------------------
Reporter: magneticore | Owner:
Type: enhancement | Status: reopened
Priority: low | Milestone:
Component: base | Version:
Resolution: | Keywords: thread
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------
Comment(by lanurmi):
I attached patches against the current trunk. With documentation.
Maybe not ready for commiting yet, but something to look at and comment
about.
IMHO, the OnDelete() function makes most sense if TestDestroy() is true
for the thread before entering OnDelete() in another context. And that's
how my patches attempt to behave.
--
Ticket URL: <http://trac.wxwidgets.org/ticket/9046#comment:13>
wxTrac
#9046: wxThread::OnDelete() and wxThread::OnKill() to add
--------------------------+-------------------------------------------------
Reporter: magneticore | Owner:
Type: enhancement | Status: reopened
Priority: low | Milestone:
Component: base | Version:
Resolution: | Keywords: thread
Blockedby: | Patch: 1
Blocking: |
--------------------------+-------------------------------------------------
Changes (by lanurmi):
* patch: 0 => 1
--
Ticket URL: <http://trac.wxwidgets.org/ticket/9046#comment:14>