Respect global MSW tooltip disabling (PR #27029)
Richard Thomson
Track the global MSW tooltip state and apply it to native toolbar tooltip windows and list-control label tips. Suppress toolbar short-help text while tooltips are globally disabled, and keep list label-tip styles in sync for existing and newly created controls.
Fixes #10072
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/27029
Commit Summary
- 40ac843 Respect global MSW tooltip disabling
File Changes
(5 files)
- M include/wx/msw/tooltip.h (8)
- M src/msw/listctrl.cpp (10)
- M src/msw/toolbar.cpp (7)
- M src/msw/tooltip.cpp (78)
- M tests/controls/listctrltest.cpp (59)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/27029.patch
- https://github.com/wxWidgets/wxWidgets/pull/27029.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27029)I'm not sure if we really want to have all this extra code to disable the tooltips in these controls — who really needs it?
And wxToolTip::Enable() is not implemented at all in wxOSX (and wxQt) and while it is implemented in wxGTK, it doesn't do anything with GTK 3.10 or later.
Maybe we should just update the docs to say that this function doesn't do anything on most platforms and only disables tooltips set with wxWindow::SetToolTip() under MSW (or maybe deprecate it entirely)?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Richard Thomson
LegalizeAdulthood left a comment (wxWidgets/wxWidgets#27029)I'm not sure if we really want to have all this extra code to disable the tooltips in these controls — who really needs it?
Presumably the person who filed the bug? :)
The bug is from 2008, almost 20 years ago. Should we just close the bug as "will not fix" and do the doc update as you suggest?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27029)Yes, I think it would be better. Tooltips are typically disabled on the touch screens, but this should be done automatically, without any special action from the application.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Richard Thomson
@LegalizeAdulthood pushed 1 commit.
- 751d82d Document wxToolTip::Enable() platform limits
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Richard Thomson
LegalizeAdulthood left a comment (wxWidgets/wxWidgets#27029)How's this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27029)Good, thank you. Will merge soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27029)BTW, as you seem to be going through all the old issues and fixing them, it would probably make sense to at least start with the ones labeled as "high priority" and/or "regression" as these are the most important ones and it would be good to address any of them that are still relevant before 3.4.0. Of course, classification is not perfect and there may be important issues not using these labels, but it seems a pity to spend time on issues such as #10072 when there are clearly many more important ones outstanding. TIA!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Richard Thomson
LegalizeAdulthood left a comment (wxWidgets/wxWidgets#27029)Fair, I was just working from oldest ones I could test locally :). I'll go through my existing issue branches and submit PRs in priority order.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.