#14490: wxFileSystemWatcher: Use reference counting for wxFSWatchInfo

[wxTrac]

Ticket URL: <http://trac.wxwidgets.org/ticket/14490>

#14490: wxFileSystemWatcher: Use reference counting for wxFSWatchInfo
-----------------------------------------------+----------------------------
Reporter: dghart | Owner:
Type: defect | Status: new
Priority: normal | Milestone: 2.9.5
Component: base | Version: 2.9-svn
Keywords: wxFileSystemWatcher wxFSWatchInfo | Blockedby:
Patch: 1 | Blocking:
-----------------------------------------------+----------------------------
As discussed in #14480 and on wx-dev, wxFileSystemWatcher (at least in
wxGTK) can't currently cope with the not-impossible situation of someone
creating a watch on a directory, and later doing AddTree() on a parent
dir. The patch implements reference counting for wxFSWatchInfo to make
this possible, and tests it in FileSystemWatcherTestCase. (It was created
on top of the #14488 patches.)

Tested successfully in FileSystemWatcherTestCase and in the 'fswatcher'
sample on wxGTK and wxMSW.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/14490>

[wxTrac]

Ticket URL: <http://trac.wxwidgets.org/ticket/14490#comment:6>

#14490: wxFileSystemWatcher: Use reference counting for wxFSWatchInfo

------------------------------------------------+---------------------------
Reporter: dghart | Owner:
Type: defect | Status: closed

Priority: normal | Milestone: 2.9.5
Component: base | Version: 2.9-svn

Resolution: fixed | Keywords: wxFileSystemWatcher wxFSWatchInfo
Blockedby: | Patch: 1
Blocking: 14544, 14544, 14544, 14544, 14544 |
------------------------------------------------+---------------------------
Changes (by VZ):

* status: new => closed
* resolution: => fixed


Comment:

(In [72679]) Make wxFileSystemWatcher watch entries reference-counted.

This helps to avoid problems that arise from watching the same physical
file
system path multiple times, which could happen when adding a watch for a
path
already watched because of a recursive watch on a parent directory, for
example.

Closes #14490.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/14490#comment:6>

[wxTrac]

Ticket URL: <http://trac.wxwidgets.org/ticket/14490#comment:10>

#14490: wxFileSystemWatcher: Use reference counting for wxFSWatchInfo

---------------------------------------------------------------------+------
Reporter: dghart | Owner:
Type: defect | Status: closed

Priority: normal | Milestone: 2.9.5
Component: base | Version: 2.9-svn

Resolution: fixed | Keywords: wxFileSystemWatcher wxFSWatchInfo
Blockedby: | Patch: 1
Blocking: 14544, 14544, 14544, 14544, 14544, 14544, 14544, 14544 |
---------------------------------------------------------------------+------

Comment(by VZ):

(In [72684]) Mention David Hart bug fixes in wxFileSystemWatcher.

See #14488, #14490, #14544.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/14490#comment:10>