In KiCad, we started experiencing a crash inside wxCocoaDataViewControl::keyEvent when a user has a french layout keyboard on macOS and they enter the ` backtick character (which when virtually remapping, is the pipe key on english keyboards).
A crash on a data view we have immediately exceptions here:
void wxCocoaDataViewControl::keyEvent(WX_NSEvent event, WXWidget slf, void *_cmd)
{
if( [event type] == NSKeyDown && [[event charactersIgnoringModifiers]
characterAtIndex: 0] == NSCarriageReturnCharacter )
{
as the charactersIgnoringModifiers is blank but characterAtIndex 0 is being called without a string length check
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.![]()
@marekr thanks for the report, all other accesses in the code seem to be protected correctly, could you please retest ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.![]()