Minor wxAuiNotebook simplification and optimizations (PR #24993)

35 views
Skip to first unread message

VZ

unread,
Dec 3, 2024, 6:47:34 PMDec 3
to wx-...@googlegroups.com, Subscribed

A few more commits extracted from my working branch.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/24993

Commit Summary

  • a53504c Forward wxAuiTabContainer::AddPage() to InsertPage()
  • 6b5f4e9 Use wxAuiNotebookPage copy ctor instead of assignment
  • fdd3e85 Simplify code in wxAuiTabContainer::InsertPage()
  • ff32a3c Simplify and optimize wxAuiTabContainer::MovePage()

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24993@github.com>

VZ

unread,
Dec 7, 2024, 12:07:10 PM (13 days ago) Dec 7
to wx-...@googlegroups.com, Push

@vadz pushed 10 commits.

  • 11eff73 Show AUI book pages order and current index in the sample
  • cb1be87 Simplify code for selecting the first page in wxAuiNotebook
  • 00f1a9c Consistently use wxNOT_FOUND for m_curPage instead of -1
  • 36786d4 Simplify page index check in wxAuiNotebook::InsertPage()
  • cfa5f18 Check page index validity in wxAuiNotebook::InsertPage() too
  • 3be543c Simplify deleting/removing pages from wxAuiNotebook
  • 68df813 Destroy, not delete, pages in wxBookCtrlBase::DoRemovePage()
  • b0735a1 Remove useless check from wxAuiNotebook::DoRemovePage()
  • 4304358 Add wxAuiTabContainer::RemovePageAt()
  • 7daba95 Assert when passed bad page index in wxAuiNotebook


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24993/before/ff32a3c64431b25eef9e28617f9eeddfc17e8f3d/after/7daba951efffe36a4a7facea0c0cb3c2e688484d@github.com>

VZ

unread,
Dec 8, 2024, 7:47:52 PM (12 days ago) Dec 8
to wx-...@googlegroups.com, Push

@vadz pushed 2 commits.

  • ea675ce Add wxAuiTabContainer::DoUpdateActive() helper
  • 1f471d2 Extract code for main tab creation into CreateMainTabCtrl()


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24993/before/7daba951efffe36a4a7facea0c0cb3c2e688484d/after/1f471d21f3a630cb749dfa4564e0901f205899f8@github.com>

VZ

unread,
Dec 9, 2024, 7:54:59 AM (12 days ago) Dec 9
to wx-...@googlegroups.com, Push

@vadz pushed 3 commits.

  • 862ec86 Make wxAuiTabContainer::ButtonHitTest() more convenient to use
  • 8c67124 Make wxAuiTabContainer::TabHitTest() more convenient to use too
  • 10baac8 Use range-for for more loops in wxAuiTabContainer


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24993/before/1f471d21f3a630cb749dfa4564e0901f205899f8/after/10baac8d863b6228bcbda0f81e38949727a23141@github.com>

VZ

unread,
Dec 9, 2024, 11:25:23 AM (12 days ago) Dec 9
to wx-...@googlegroups.com, Subscribed

Merged #24993 into master.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24993/issue_event/15586581065@github.com>

Reply all
Reply to author
Forward
0 new messages