Use SetPixelV for ignored MSW pixel writes (PR #27028)

13 views
Skip to first unread message

Richard Thomson

unread,
Sep 20, 2026, 12:57:55 AM (6 days ago) Sep 20
to wx-...@googlegroups.com, Subscribed

Use SetPixelV() in wxMSWDCImpl::DoDrawPoint() and native toolbar bitmap colour remapping where the SetPixel() return value is ignored. This keeps the existing drawing and colour-remapping logic unchanged while avoiding the unused colour return.

Fixes #10011


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/27028

Commit Summary

  • ec71590 Use SetPixelV for ignored MSW pixel writes

File Changes

(2 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/27028@github.com>

VZ

unread,
Sep 20, 2026, 12:03:29 PM (6 days ago) Sep 20
to wx-...@googlegroups.com, Subscribed
vadz left a comment (wxWidgets/wxWidgets#27028)

Thanks, this probably shouldn't have any regressions compared to SetPixel().

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/27028/c5750926543@github.com>

VZ

unread,
Sep 20, 2026, 12:57:46 PM (6 days ago) Sep 20
to wx-...@googlegroups.com, Subscribed

Closed #27028 via 6dc581f.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/27028/issue_event/31486890608@github.com>

Reply all
Reply to author
Forward
0 new messages