CMake uses C++-specific options for C files too (Issue #22696)
VZ
Doing
$ cmake -S . -B ~/build/wx/cmake -GNinja
$ cmake --build ~/build/wx/cmake
results in the following output
[2/794] Building C object libs/base/CMakeFiles/wxbase.dir/__/__/__/__/src/common/extended.c.o
cc1: warning: command-line option ‘-Wno-ctor-dtor-privacy’ is valid for C++/ObjC++ but not for C
cc1: warning: command-line option ‘-Woverloaded-virtual’ is valid for C++/ObjC++ but not for C
[5/794] Building C object libs/core/CMakeFiles/wxcore.dir/__/__/__/__/src/gtk/treeentry_gtk.c.o
cc1: warning: command-line option ‘-Wno-ctor-dtor-privacy’ is valid for C++/ObjC++ but not for C
cc1: warning: command-line option ‘-Woverloaded-virtual’ is valid for C++/ObjC++ but not for C
It's harmless, but it would be nice if we could avoid these warnings by using separate C and C++ warning options.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
This can be fixed by adding those warnings only for CXX compiler, like: $<$<COMPILE_LANGUAGE:CXX>:${cpp_only_warnings}>
I'll create a PR with this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
I think this should be safe to backport to 3.2, shouldn't it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
Yes, this can be backported.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Thanks, I've actually already done it and forgot to close this (it's really inconvenient not to be able to use Closes #NNNN in 3.2 branch).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Closed #22696 as completed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.