Update filedlg.cpp (PR #23944)

charvey2718

unread,

Oct 5, 2023, 12:39:24 PM10/5/23

to wx-...@googlegroups.com, Subscribed

Fixes for issue #10924

You can view, comment on, or merge this pull request online at:

https://github.com/wxWidgets/wxWidgets/pull/23944

Commit Summary

2fb7ba9 Update filedlg.cpp

File Changes

(1 file)

M src/msw/filedlg.cpp (4)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

VZ

unread,

Oct 5, 2023, 12:44:36 PM10/5/23

to wx-...@googlegroups.com, Subscribed

Thanks, but could you please extract this into a trivial function in the beginning of this file, to make updating it later easier?

And, in fact, thinking more about it, I think we may want to amend this slightly by breaking from the loop after some big (1000? 10000?) number of iterations, just to be 100% sure that we don't get stuck forever if the user has a vibrating mouse generating events all the time or something other like this, which seems impossibly contrived and unrealistic until you run into it in practice...

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

charvey2718

unread,

Oct 5, 2023, 12:49:41 PM10/5/23

to wx-...@googlegroups.com, Subscribed

No worries - I'll get onto this later.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

charvey2718

unread,

Oct 5, 2023, 3:41:00 PM10/5/23

to wx-...@googlegroups.com, Push

@charvey2718 pushed 1 commit.

8c77109 Update filedlg.cpp

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

charvey2718

unread,

Oct 5, 2023, 3:51:56 PM10/5/23

to wx-...@googlegroups.com, Subscribed

@vadz I've done as you requested. Can you see the improvements as part of this PR or do I need to renew it somehow?

charvey2718 is fine for the change log, thanks.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

VZ

unread,

Oct 5, 2023, 7:04:34 PM10/5/23

to wx-...@googlegroups.com, Subscribed

Thanks! I'm going to merge this in master with some minor changes (mostly more comments to explain what's going on here and, also, a better commit message) soon and also apply it to 3.2 branch so that it is included in the upcoming 3.2.3 release.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

VZ

unread,

Oct 5, 2023, 7:07:41 PM10/5/23

to wx-...@googlegroups.com, Subscribed

Closed #23944.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Dave Nadler

unread,

Jun 22, 2025, 7:08:43 PM6/22/25

to wx-...@googlegroups.com, Subscribed

DRNadler left a comment (wxWidgets/wxWidgets#23944)

Please note: This is a general problem for any dialog containing a wxListBox for example (probably any control that processes a double-click). If the handler dismisses the dialog, the left-up or move events may happen after the dialog is dismissed...