Enable building wxGTK without GLX (PR #26146)
Chris Mayo
Set wxHAS_GLX if GTK 3 with GDK_X11.
I've added non-configurable support to configure in a separate commit due to my limited autoconf skills - but this at least maintains the current situation for configure.
Closes #26145
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26146
Commit Summary
File Changes
(8 files)
- M build/cmake/init.cmake (3)
- M build/cmake/setup.h.in (3)
- M configure.ac (1)
- M include/wx/glcanvas.h (6)
- M setup.h.in (3)
- M src/gtk/glcanvas.cpp (4)
- M src/unix/glcanvas.cpp (6)
- M src/unix/glx11.cpp (2)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26146.patch
- https://github.com/wxWidgets/wxWidgets/pull/26146.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Chris Mayo
@cjmayo pushed 2 commits.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Chris Mayo
@cjmayo pushed 1 commit.
- 9b3e714 Run autogen.sh
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Chris Mayo
@cjmayo pushed 1 commit.
- acd4677 Run autogen.sh
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Chris Mayo
cjmayo left a comment (wxWidgets/wxWidgets#26146)What to do about wxGTK 2 - is it reasonable to set wxHAS_GLX?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
Thanks for the fix, I have indeed completely forgotten that GLX might not be available either.
I'm not sure why does the PR only define wxHAS_GLX for wxGTK3, surely it should do it if OpenGL headers/libraries are found, for any port (and then stop doing it for wxX11 in the header)?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26146)What to do about wxGTK 2 - is it reasonable to set wxHAS_GLX?
Yes, and for wxX11 too, please. I.e. just don't test for the toolkit at all — if OpenGL headers/libraries are available, define this symbol.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.