Fix ParseDateTime to handle default 'T' separator (PR #22999)
Blake-Madden
ParseDateTime currently fails if there is a 'T' separator in front of time component. FormatISOCombined() uses this separator as the default, so wxDateTime can't parse its own formatted results by default. Example
wxDateTime dt; wxASSERT(dt.ParseDateTime("1979-10-31 13:37:09")); wxASSERT(dt.IsValid()); wxDateTime otherDt; // OK wxASSERT(otherDt.ParseDateTime(dt.FormatISOCombined(' '))); // Fails using the defaults (and, according to the help, the standard format) wxASSERT(otherDt.ParseDateTime(dt.FormatISOCombined()));
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/22999
Commit Summary
- 616e5f4 Fix ParseDateTime to handle 'T' separator
File Changes
(1 file)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/22999.patch
- https://github.com/wxWidgets/wxWidgets/pull/22999.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- afc6cfb Fix whitespace
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Lauri Nurmi
A unit test for this should be added to tests/datetime/datetimetest.cpp.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- 0d679a9 Add unit test
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Looks good, thanks! Will merge soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.