Add dark mode support to wxMSW task dialog-based dialogs (PR #26570)
VZ
This is #26311 with cleanup and some fixes.
Unfortunately there are still ressource leaks remaining: every time a message box is shown, 3 GDI handles (and 1 USER one) are leaked. I can't figure out what they are: Application Verifier doesn't show anything at all and GDIView shows the total number of handles growing while each column remains stable. It also shows the total number increasing by 6, unlike the task manager which only shows 3 leaked handles.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26570
Commit Summary
- 92254ce Factor out wxIsSystemColourChange() helper function
- 8e2ac38 Add dark mode support for task dialog-based dialogs
- 2ebde40 Remove WM_SETTINGCHANGE handling from task dialog proc
- 091ba7a Remove unnecessary member initialization in TDPageState ctor
- 0dce46f Use AutoHBRUSH instead of manually allocating/deleting HBRUSHes
- 12eed00 Make IUIAutomation pointer a local variable
- 8048524 Return TRUE, not 1, when handling WM_ERASEBKGND
- 3ed49f0 Use safer wxIID_PPV_ARGS() instead of cast to "void**"
- 739cefe Localize GET_[BGR] macros
- e1ca1dd Use wxColour and wxUxThemeHandle instead of raw Windows API
- 8b2b906 Don't define CLSID_CUIAutomation and IID_IUIAutomation ourselves
- fac69ca Add default ctor and move assignment to wxUxThemeHandle
- 1c6d7e9 Don't use thread-local in task dialog dark mode support code
- a5979f4 Add helper GetHWNDFromElement(IUIAutomationElement) function
- db39a68 Stop using wxBasicString unnecessarily
- e0a95d5 Rename LPARAM parameter to standard "lParam" name
- dede73a Don't store IUIAutomation in TDEnumData
- bd03fbb Don't pass IUIAutomation as parameter to TDApplyToChildren()
- 88b1caf Reuse GetWindowDPI() from task dialog dark mode code
- 026e93d Check for error after calling ::SetWindowTheme()
- 6d45067 Remove TDPageState::CloseThemes()
- 683d735 Remove TDPageState::hTDS which was same as hTD
- 3969155 Remove TDPageState::isDark
- 23409e0 Don't do anything in TDPaintGlyphs() when using native dark theme
- 847561b Extend wxUxThemeHandle and use it more in dark task dialog code
- 3de0aec Add WinStructWordSize<> helper and use it
- 26bf503 Use recently added wxUxThemeHandle::GetFont()
- 5acd403 Reformat task dialog dark mode support code
- 8ab0173 Add GetCurrentAutomationId() helper
- b5baa3e Remove unnecessary "static" from functions in anonymous namespace
- 361dbd9 Use wx-specific subclass IDs
- 272875a Add wrappers around window subclassing functions
- a2d7a75 Fix HBRUSH leaks in task dialog dark mode code
File Changes
(24 files)
- M Makefile.in (36)
- M build/bakefiles/files.bkl (1)
- M build/cmake/files.cmake (1)
- M build/files (1)
- M build/msw/makefile.gcc (28)
- M build/msw/makefile.vc (28)
- M build/msw/wx_core.vcxproj (1)
- M build/msw/wx_core.vcxproj.filters (3)
- M include/wx/msw/private.h (38)
- M include/wx/msw/private/darkmode.h (5)
- A include/wx/msw/private/taskdlg.h (56)
- M include/wx/msw/uxtheme.h (59)
- M src/msw/darkmode.cpp (20)
- M src/msw/datecontrols.cpp (3)
- M src/msw/joystick.cpp (15)
- M src/msw/msgdlg.cpp (30)
- M src/msw/progdlg.cpp (21)
- M src/msw/renderer.cpp (3)
- M src/msw/statbox.cpp (10)
- A src/msw/taskdlg.cpp (1276)
- M src/msw/toolbar.cpp (3)
- M src/msw/utils.cpp (4)
- M src/msw/uxtheme.cpp (50)
- M src/msw/window.cpp (16)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26570.patch
- https://github.com/wxWidgets/wxWidgets/pull/26570.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 2 commits.
- 2580e62 Include wx/brush.h to fix the build when not using PCH
- c2f3ee8 Disable support for dark mode in task dialog for wxUniv
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 2 commits.
- 1ec6163 Include wx/brush.h to fix the build when not using PCH
- 37ff69e Disable support for dark mode in task dialog for wxUniv
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- 97c1f3b Ignore unused parameters when dark mode support is disabled
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- 53d16f0 Fix HICON leak in task dialog dark mode support code
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26570)I was looking for the leaks in a wrong place, we've been actually leaking HICONs, of all things... AFAICS this is fixed now, neither GDIView nor Process Explorer show any handles growth when repeatedly opening and closing a message box.
There is still the fact that a lot of resources are allocated the first time this happens, but I think we can live with it, so this should be ready for merge if nobody sees any big problems with it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.