Some fixes for building with CMake on MSYS2/MinGW-w64 (PR #25466)

مهدي شينون (Mehdi Chinoune)‎

unread,

May 28, 2025, 11:30:06 PM5/28/25

to wx-...@googlegroups.com, Subscribed

You can view, comment on, or merge this pull request online at:

https://github.com/wxWidgets/wxWidgets/pull/25466

Commit Summary

9a58749 Use copy instead of create_symlink for CMake commands on Windows
c3f3c07 Add an option wxUSE_MSVC_NAMING
044f4f3 Install runtime binaries on bin directory when not following MSVC structure.

File Changes

(5 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

مهدي شينون (Mehdi Chinoune)‎

unread,

May 28, 2025, 11:55:40 PM5/28/25

to wx-...@googlegroups.com, Push

@MehdiChinoune pushed 1 commit.

924d279 Don't disable wxUSE_DBGHELP on MinGW-w64

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

مهدي شينون (Mehdi Chinoune)‎

unread,

May 29, 2025, 12:38:32 AM5/29/25

to wx-...@googlegroups.com, Push

@MehdiChinoune pushed 1 commit.

e816a11 Fix making symlinks/copies for wxrc and wx-config

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

VZ

unread,

May 31, 2025, 10:08:39 AM5/31/25

to wx-...@googlegroups.com, Subscribed

vadz left a comment (wxWidgets/wxWidgets#25466)

Thanks for the fixes, but I'm a bit afraid to apply such changes just before 3.3.0. @MaartenBent Could you please review this? If you think it's ok (as in "doesn't break anything for the other build configurations"), I'll merge it now, otherwise I'd rather do it before 3.3.0.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

مهدي شينون (Mehdi Chinoune)‎

unread,

Jun 1, 2025, 4:37:26 AM6/1/25

to wx-...@googlegroups.com, Subscribed

Closed #25466.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Maarten

unread,

Jun 2, 2025, 7:16:34 PM6/2/25

to wx-...@googlegroups.com, Subscribed

MaartenBent left a comment (wxWidgets/wxWidgets#25466)

As far as I can see the 'breaking' changes are:

Always using copy instead of create_symlink on Windows. I'm fine with this, but maybe it is better to make this a build option. Something like wxBUILD_INSTALL_USE_SYMLINK with options NO, YES and DEFAULT (no on Windows, yes on Linux/macOS).
Add $ENV{DESTDIR} to symlink/copy source. This looks like a bug fix.

And other changes:

Making WIN32_MSVC_NAMING an option, fine with me.
Enabling wxUSE_DBGHELP for MinGW, fine with me.
Changing runtime_default_dir. Seems logical to have this dependent on WIN32_MSVC_NAMING. AFAIK it doesn't change behaviour, except maybe for CMAKE_CROSSCOMPILING, which is probably fine. Note that you can also override this with wxBUILD_INSTALL_RUNTIME_DIR.

I think this needs more testing than I can do before 3.3.0, so might be best to not include it. And since the PR has been closed maybe it is not needed anymore...

Nonetheless these are some good suggestions so I'll try to test them and create a PR myself in the near future.