Respect disabled physical scrolling in Scroll (PR #26900)
Richard Thomson
Make wxScrollHelper::DoScroll() use ScrollWindow() only for axes whose physical scrolling is enabled. Disabled axes still update their logical scroll position and invalidate the target window so it repaints.
Add a regression test covering fully disabled physical scrolling and a mixed horizontal-enabled, vertical-disabled scroll.
Fixes #4433
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26900
Commit Summary
- ec1e29c Respect disabled physical scrolling in Scroll
File Changes
(2 files)
- M src/generic/scrlwing.cpp (41)
- M tests/controls/windowtest.cpp (70)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26900.patch
- https://github.com/wxWidgets/wxWidgets/pull/26900.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26900)I'm not sure if we really want to do this. In wx, disabling something means preventing the user from doing it, but the program should still be able to do it.
Unless there is some good reason to prevent the program itself from scrolling the window (which?), I'd rather close both this and the original issue.
Any other thoughts?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
RobertRoeb
RobertRoeb left a comment (wxWidgets/wxWidgets#26900)Hm, I sympathise with the patch - not sure. Maybe the OP can describe a situation when this happened so we can consider again.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Richard Thomson
@LegalizeAdulthood pushed 1 commit.
- e937083 Respect disabled physical scrolling in Scroll
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.