[MSW] Without wxUSE_UXTHEME, some controls get the wrong border (Issue #23401)

10 views
Skip to first unread message

Brian Nixon

unread,
Mar 30, 2023, 9:16:24 AM3/30/23
to wx-...@googlegroups.com, Subscribed

Description

Without wxUSE_UXTHEME, wxBORDER_DEFAULT becomes wxBORDER_THEME in wxControlBase::GetDefaultBorder(), which is unaffected by wxWindowMSW::TranslateBorder() and so in wxWindowMSW::MSWGetStyle() effectively means ‘none’. To preserve the native look, controls should have wxBORDER_SUNKEN. (Or maybe wxDEFAULT_CONTROL_BORDER?) This shows up glaringly on Windows 7 classic.

Affects at least wxListBox, wxListCtrl and wxTextCtrl. (There may be others; I haven’t tested exhaustively.)

Relatedly: wxSpinCtrl and wxTreeCtrl explicitly set wxBORDER_SUNKEN in their Create() functions.

Platform and version information

  • wxWidgets version you use: 3.2.2.1
  • wxWidgets port you use: wxMSW
  • OS and its version: Windows 7 [Version 6.1.7601]


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/23401@github.com>

VZ

unread,
Mar 30, 2023, 9:19:28 AM3/30/23
to wx-...@googlegroups.com, Subscribed

Do you have any good reason to disable wxUSE_UXTHEME? So many things depend on it that it would be rather painful to fully support not using it, so I wouldn't want to spend any time on this unless it's really needed. In fact, I'd rather drop this option entirely, to be honest.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/23401/1490292244@github.com>

Brian Nixon

unread,
Mar 30, 2023, 9:36:49 AM3/30/23
to wx-...@googlegroups.com, Subscribed

Closed #23401 as not planned.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issue/23401/issue_event/8887701152@github.com>

Brian Nixon

unread,
Mar 30, 2023, 9:36:49 AM3/30/23
to wx-...@googlegroups.com, Subscribed

Do you have any good reason to disable wxUSE_UXTHEME?

Not really.

Closing WONTFIX


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/23401/1490319074@github.com>

Reply all
Reply to author
Forward
0 new messages