Re: wxSocket without timeout (#9443)

2 views

Skip to first unread message

Richard Thomson

unread,

6:32 PM (4 hours ago) 6:32 PM

to wx-...@googlegroups.com, wxtrac, Author

LegalizeAdulthood left a comment (wxWidgets/wxWidgets#9443)

The problem with SetTimeout(-1) is that the existing API uses an unsigned argument, so now you're inviting signed/unsigned conversion warnings. If you change the signature of SetTimeout, then existing callers may generate signed/unsigned conversion warnings and this will break warnings-as-errors builds.

Is a better API shape an explicit method that disables the timeout and a getter to tell you if the timeout is disabled?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you authored the thread.

Reply all

Reply to author

Forward

0 new messages