(RM-77291) Reverted DoDrawPoint() to the 3.1.2 implementation (PR #27045)

11 views
Skip to first unread message

Iolanda Asavei

unread,
Sep 21, 2026, 1:31:35 PM (yesterday) Sep 21
to wx-...@googlegroups.com, Subscribed

The current implementation performs intensive pen and brush creation, which can trigger reference counting races and crashes when drawing is performed outside the GUI thread (Sheet set - drawing preview).

You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/27045

Commit Summary

  • 1629793 [api-change] Added new param 'bool batchMode' to 'wxPrinterBase::Print()'.
  • cd6a2e1 [api-change] (Windows only) Added Detach() method to wxBitmap class.
  • 5203aca [api-change] Expand the deactivate hack condition for qt transient popup.
  • d36792f [api-change] Add wxScintilla support for DCL + AutoLISP.
  • a8c9880 Add files by bricscad's cmake config refs RM-69969
  • df1dfb7 Add AUIDocMDI files.
  • cb6c523 wx upgrade: add MSVC_TOOLSET_VERSION to folder naming scheme.
  • a745432 wx upgrade: add build_wx.py build script
  • 963248b [api-change] Reenable wxMetaFile.
  • d0cd013 [api-change] [COPILOT] Add GetPreview() getter to wxPreviewCanvas
  • c09f619 [fix-build] Fix bricscad hanging on the dwg opening on mac when build against 10.14
  • e35f8c5 [api-change] Use generic spinctrl instead of native GTK3.
  • 463a53a [api-change] Added possibility to prevent unloading dlls with FreeLibrary() for memleaks reporting.
  • 2bacf24 Implemented working in modal mode for wxMenuItem on Mac only
  • a5bd939 [api-change] make combo control FOCUS_RING value customizable per object
  • 64c1849 replaced wxRangeT class by wxTextInputRange
  • 25c9fc3 wxWidgets now use -fvisibility=hidden on Mac/Linux. We use wxGridCellEditorEvtHandler in bricscad code, so we need to export its symbol
  • 60eface Qt: associate QNSView s with their wxWidgetImpl parent.
  • b0a7fdd wxCursor improvements
  • 9fd5de6 add means to enable/disable accelerator table entries
  • ee384b3 Further accelerators improvements
  • e751a06 make wxApp::m_openFiles protected instead of private
  • a78dc9d Crosshair improvements
  • 01ffbd4 improved wxApp::hideAppOSX()
  • b9cc4a0 Linux: disable library versioning (SONAMES).
  • 4dc7bbf Added VENDOR=bricsys.
  • eb2f9aa [api-change] Added wxToolBar::GetToolRect(), used by our flyout
  • 9dd01a8 Fixed GetValueAsString for unattached wxPGProperty
  • 4d97317 Removed menu item ID upper-limit assertion
  • 291493d Controls are now omitted and hidden on vertical Aui toolbars.
  • 389f457 Used parent/default font values for unrealized Gtk3 toolbars
  • e747d7a When tree receives WM_CONTEXTMENU, select the item.
  • 14b84db Commented out wxRadioBox code that conflicts with MFC radiobuttons.
  • 4988c50 Open context help immediately (instead of question-mark cursor).
  • c839770 fixed docking of vertical toolbars when wxAUI main frame is maximized
  • 09d4d7a Propgrid: when selecting a property in a collapsed category, expand all parent categories.
  • 191a1d8 Commented out treatment backslash as escape symbol for following '%' and '$' chars.
  • 1e4046b Fixed in wxRegConfig class: HKLM must never be queried when wxCONFIG_USE_GLOBAL_FILE flag is not set
  • 315d4dc Allowed properties with identical names what is required in explorer.
  • 18577ce Fixed: system display configuration dependent crash on dragging entities, snapping or exporting to EMF.
  • 2d9470f Restored check 'IsWindow()' to prevent error output upon closing an application.
  • d4c44d1 Using GTKConvertMnemonics with wxGetStockLabel to allow proper translation of standard buttons.
  • 17eb667 Completing application of original r2323.
  • cd3573f Copilot wxupgrade - prompt for merging. refs RM-69972
  • b52c947 Replaced tabs with spaces.
  • 2aea73b DdeClientTransaction() call made asynchronous in wxDDEConnection::Execute().
  • e7431b7 Redefine wxID_AUTO_LOWEST : wxID_AUTO_HIGHEST as a positive range.
  • 4d16d3a For list controls of type wxLC_REPORT size was set to some arbitrary value.
  • f3229ac Drawing Explorer, Panes' captions use a new font; correct this by setting the old font back.
  • 56fd7c4 Added and implemented API for rotated output to wxPostScriptDC using wxPostScriptPrintNativeData.
  • eeafa12 Fixed problem european charsets other than UTF8 encoding.
  • 1fbfcb1 Fix event propagation for wxEditableListBox.
  • a8ce4ff When a property control is focused, GTK scrolls the window as well, but somehow incorrectly.
  • 46a3b04 Fix compilation on mac: remove macro 'check'.
  • e0f9935 Deactivated the gripper in wxAuiManager::Update() when the manager is floating.
  • bf06748 wxBMPHandler::LoadDib now checks BMP file signature first
  • 24ba4bb Print preview for A3 with more than one viewports fails with insufficient memory on Win 32 bit.
  • 6874585 File dialog: don't append a default extension to the filename.
  • 47d3f1d Fixed a wxCollapsiblePane zero size problem.
  • 7da680e Make wxPropertyGrid::HandleCustomEditorEvent() virtual.
  • 1a1f801 (Win) Use correct font instead of DEFAULT_GUI_FONT
  • e2123c6 Forced GTK menu icons in GNOME
  • 9193f09 Disabled wx asserts in Windows release builds
  • 50e0e8f Committing implementation for some functions in wxAuiToolBar to make it more compatible with wxToolBar.
  • dc7b3fd Commit fix for wxAuiToolBar::DeleteTool() when the tool contains a window.
  • f98315d Added sanity check / fix for weakness in WX wxPGProperty::SetChoices().
  • a3aeb3c (Mac) Fix for drawing preview.
  • fb7b382 (Mac) Adjust button sizes on OS X for our owner drawn combo boxes.
  • d6bf2fd (Mac) Wx assert dialogs with a long message.
  • 66e5b6a Remove Close/Minimize/Maximize buttons from floating panes on Mac
  • 80615ec (Win) Force custom DPI in print preview for printers that don't accept it
  • 4215a86 Fix initial sash position when gravity is set on Mac
  • 103f55a Fix file dialog filter selection on Mac for open and save
  • 707ccca Fix wxIsWritable() for directories on Windows by creating temp file
  • 949b5a3 Reset text cursor position after wxTextCtrl::Clear() on Mac
  • 961028b Improve floating toolbar dragging on Mac
  • 89107ec Fix crash when setting selection in empty combo boxes on Mac
  • 59b258e Fix child windows remaining visible when main window minimized on Mac
  • d8b87b1 Add support for RTLD_DEEPBIND flag in wxDynamicLibrary on Linux
  • f89f08b Enable native double buffering for wxPropertyGrid on Mac
  • 0dc76cd Rename parameter 't' to 'transform' in wxGraphicsMatrix to avoid macro conflicts
  • 4a66367 Fix custom paper size selection on Mac
  • 306fe07 wxEditableListBox: replaced button icon images
  • ea63ec1 (Mac) wxComboBox: exclude wxCB_SORT on macOS
  • d7ec0b1 wxPropertyGrid: fix Prev() iterator for deeply nested items
  • d14b622 Add wxTheApp null check in logg.cpp
  • 273def9 PropGrid: Skip readonly properties on TAB
  • e7a9797 Fix grid column drag detection
  • af2324c Flush log messages before destroying wxTheApp
  • 5f467dc Fix pending objects deletion during event processing
  • b09c6db Remove row labels when deleting grid rows
  • aef0354 wxDocManager: disable auto-activation after document creation
  • 6a9d25c wxTreeCtrl: disable refresh workaround for performance
  • 79003e6 wxMenu: fix EVT_MENU_OPEN on Ubuntu Unity
  • 71e418e wxCHMHelpController: respect NULL parent window
  • 2aa1195 wxFrame OSX: restore focus on frame reactivation
  • e20cef3 wxTreeCtrl: add keepSelection option to Collapse methods
  • 1dbda84 Mac: Enter key activates default button in dialogs
  • 1d56f91 XML: Optimize resource parsing performance
  • 5f82c68 Mac: Support SetBackgroundColour on buttons via bitmaps
  • f0f6473 Mac: Make wxSearchCtrl::Create() virtual
  • 307abb5 ListCtrl: Single-click activation and context menu fix
  • 8c431b9 AUI: Fix crash when GetPage returns nullptr
  • 4f0faa9 Add support to wxAuiTabCtrl for vetoing tab dragging
  • 45542f3 Add wxSEMIBOLD deprecated constant and font weight handling
  • cf14f7f Make wxToolTip transparent to mouse down events on Windows
  • 82e21f0 Add wxCURSOR_NOT_ALLOWED cursor for drag and drop on macOS
  • 1365560 Fix double destruction in wxRichToolTipPopup
  • ac0d90a Rename LayoutControls to DoLayoutControls in wxSearchCtrl
  • 6ddfe13 Fix tab focus rectangle for collapsed tabs
  • 4b5d60f fixup! fixup! Registry: Handle expandable environment variables properly
  • f328209 Fix wxAuiNotebook crash when removing pages
  • b32cee2 Add arrow key handling to wxTextEntry without modifiers
  • f3eed87 Add Page Up/Down key handling to wxScrolled
  • a1cc4a4 Add focus tracing to GTK toplevel window
  • 7f82015 Fix scroll button state in AUI notebook
  • 22652d3 Force generic data view control on all platforms
  • 5a76032 Disable column update in data view control
  • 0c00b42 Convert source file encoding to UTF-8
  • cc99af8 Block move events during AUI pane update
  • c636e23 Add wxDL_AS_DATAFILE flag for Windows
  • 8333724 Make wxPGProperty::SetFlag public
  • aefac26 Fixed bug: failure in GetFieldRect results in uninitialized values
  • 62ed35d Revert tree control freeze/thaw to custom implementation
  • 381f304 Document DOCHOSTUIFLAG_DPI_AWARE as Bricsys addition
  • 53e29eb Fix intermittent GUI test failures in dialog destructor
  • 0e75e48 Add filename to XRC version mismatch log message
  • d5a05c5 Remove unnecessary Update() call for better performance
  • 4911ace Use plain no-op function for wxTrap on unix
  • 9e2af8e Avoid wxColour assert on OS X for invalid colours
  • 0604388 Support reparenting combo popup window
  • ab8530f Fixed incorrect handling of non-bitflag button styles
  • 3996d46 Fix tab close button size and color on hover
  • af9781c Support null background color in property grid cells
  • 5086240 Fix wxComboBox dropdown sizing on Mac when themed
  • bd157b6 Fix enabling TLW to respect children's previous state
  • c2463b2 Fix registry path un-expanding for 8.3 format filenames
  • 4b52202 Support custom theming in generic list control
  • 20fede6 Override hardcoded status bar colors on Mac for theming
  • 9766808 Suppress image load error dialogs when verbose flag disabled
  • 78975b0 Remove child properties from deletion/removal pending lists
  • 8cbb84f Remove completed thread handle from global list
  • 997eda1 Make size of expand/collapse buttons in wxPropGrid be DPI aware
  • 53ba216 Support custom button hover effect color with custom background
  • e1a0c6b Add macOS app chooser for opening files without default app
  • c67a2c0 Optimize rich text wrapping performance
  • 65c4f75 Fix scroll position with delayed layout in rich text
  • 207a8be Restart tooltip delay per property in wxPropertyGrid
  • 5b5b633 Fixed trackpad rubbersheet gestures with dynamic dimensions
  • abc1c47 Fixed context menu for Drawing Explorer on Mac
  • 1e9b63c Fixed Project Browser tooltips not appearing
  • 08bb8de Disable automatic text color in AUI tabs for theming
  • aab6966 Forward keyboard events in rich tooltip to parent
  • e457c1e Add Retina support for macOS wxGLCanvas
  • faa5dfc Allow theming of wxCheckListBox text color
  • 4b16ba0 Avoid crash in WX_filterSendEvent on mac
  • 5507a90 Avoid infinite onpaint events on macOS Big Sur
  • dc20457 Fixed crash with single-character filename
  • d298d15 Improve wx toolbar gripper
  • bb0ba01 Fix checkmarks width on Linux
  • ed4c206 Labels displayed wrong in composition panel
  • 726ceec Visual improvements to menus - disable Emoji and Start dictation
  • bd8ca1d Prefer enabled main frame window as message box parent
  • 7cffabf Fix property grid button handling and margins
  • 53df25b Fix can't highlight entities
  • 5c2a35d Fix crash in wxVListBoxComboPopup during destruction
  • ba1e87f Fix wxAuiMSWTabArt to use selected font for active tabs
  • e102074 Remove launch sh script on MacOS
  • 4fedb22 Add keyboard shortcuts for property grid editor on macOS
  • ae4ca0c Remove Bricsys-specific code for matching braces highlight
  • bfbd281 Fix unix build warnings
  • bfad387 Fixed by allowing to use generic implementation
  • 4de66fe Merge r2328 changes: BRICSYS_WX_2_8_COMPAT, strvararg x64 fix, dcpsg pen fix, msgdlg active window
  • 65f8054 Merge r2360 changes: PostScript DC clipping region improvements
  • cee7797 Merge r2388: make read-only comboboxes expand when clicked on macOS
  • 4c8e4f2 Reparent(nullptr) fix on Mac
  • 037df9f Keep non-modal Cocoa dialogs above parent
  • e94f545 Silence propgrid DLL Release warning 4723
  • 4aaa16b Disable native theming for top MSW AUI tabs
  • 98edf28 Relax registry key access and deletion checks
  • ec389ea fixup! Document DOCHOSTUIFLAG_DPI_AWARE as Bricsys addition
  • bfa86ba fixup! [api-change] Add wxScintilla support for DCL + AutoLISP.
  • af4665a Remove Ribbon completely from the build - wxUSE_RIBBON=OFF.
  • 22d427a Fix macOS build errors
  • bacb7d7 Revert "Fix macOS build errors"
  • 1905b73 fixup! Fix Mac menu handling and app activation (GH-44)
  • 1814ffd fixup! Themed buttons on MacOS 10.15 Catalina (GH-50)
  • 142c027 fixup! Fixed context menu for Drawing Explorer on Mac (GH-49)
  • 597cb88 fixup! Add wxCURSOR_NOT_ALLOWED cursor for drag and drop on macOS (GH-51)
  • 1b2ee64 Fix bug in combos from Properties panel. (GH-54)
  • 5ba1f0e fixup! (Win) Use correct font instead of DEFAULT_GUI_FONT (GH-55)
  • dea63ef Restore wxINVERT for wxPGProperty category focus rect to fix dark theme visibility (GH-56)
  • b762f9b Take default cmake path from THIRDPARTY_PATH.
  • bed7e5a build_wx.py: resolve install paths as relative to src_dir.
  • 9dd4ff7 build_wx.py: add --config BUILD_TYPE for MSVC builds.
  • 15e53b6 Disabling wx asserts in release on Windows.
  • 9cbc194 Release builds should use RelWithDebInfo.
  • 6992b3d fixup! Improve touch event detection and threshold handling on Mac (GH-53)
  • 89ced4e fixup! Release builds should use RelWithDebInfo.
  • faddaf9 fixup! wxFrame OSX: restore focus on frame reactivation (GH-52)
  • 71857f5 Fix small memory leak in wxNSCustomOpenGLView
  • 7473c7e Revert "Fix adding icons with mask to wxMSW wxImageList" (GH-59)
  • 51af654 Make wx binaries compatible with the application expectation (#60)
  • 40dd32e fixup! Committing implementation for some functions in wxAuiToolBar to make it more compatible with wxToolBar. (GH-62)
  • 14c9dd8 Lexlisp fix (GH-61)
  • c69a084 fixup! Fix pending objects deletion during event processing (GH-63)
  • cfb1e7c wxWidgets builds ARM by default on Windows (GH-65)
  • 103f731 AUI: add GetToolBar() to wxAuiToolBarItem. (GH-64)
  • 012eb36 MSW: call SetupBitmaps() immediately in DoInsertOrAppend() (GH-66)
  • 0b63413 build: fix CMake warnings for unused variables
  • 570d25b fixup! [api-change] Resize quality option for StretchBlit
  • d1fe3a1 fixup! Merge r2328 changes: BRICSYS_WX_2_8_COMPAT, strvararg x64 fix, dcpsg pen fix, msgdlg active window
  • c50f0cc fixup! Fixed Project Browser tooltips not appearing
  • 4af0218 fixup! Disable column update in data view control
  • 241341b fixup! Disable automatic text color in AUI tabs for theming
  • fca110b fixup! fixup! (Win) Use correct font instead of DEFAULT_GUI_FONT (GH-55)
  • 894bfb5 fixup! [api-change] Added methods SetCustomPaperId()/GetCustomPaperId() in wxWindowsPrintNativeData
  • 2ad8b6d Fix build warnings on Windows.
  • ad68c85 fixup! Merge r2515: fix expanding of %ProgramFiles(x86)% env variable
  • 1d10d0d fixup! Commented out treatment backslash as escape symbol for following '%' and '$' chars.
  • d709791 fixup! Merge r3058: use menu_show signal instead of menu_map for GTK menus
  • 6298886 Set En-US Keyboard layout for accelerator table initialization (GH-69)
  • ca5001e fixup! Set En-US Keyboard layout for accelerator table initialization (GH-69)
  • 547ff02 build_wx: add argument -j / --jobs for parallelize builds.
  • 03bb5d4 Replace 'Qt' with 'Wx'
  • 4f3d769 msw: fix custom colours ignored by DrawThemeText in native header (GH-70)
  • fbf0190 Disable wxUSE_WEBREQUEST_CURL, it is set to true by default on Linux, regardless of wxUSE_WEBREQUEST=OFF.
  • 1effe07 Force CMAKE_INSTALL_LIBDIR to 'lib' as this is what Bricscad has hardcoded (copy_dependencies.sh etc)
  • babdd36 build/bricsys/build_wx.py fixes
  • b62155e fixup! build/bricsys/build_wx.py fixes
  • 83f5a00 test
  • aac5ae5 fixup! test
  • b03103c rm-44840
  • 55378c9 applied review remarks
  • a2b9026 [Accelerators] Ctrl+F accelerator doesnt work for Czech keyboard layout
  • 6126ae9 Support building both release and debug at the same time
  • 3251ce0 fixup! Add wxCURSOR_NOT_ALLOWED cursor for drag and drop on macOS (GH-78)
  • cfe21ec fixup! [api-change] Added row dragging and improved move events to wxGrid
  • c5be24f Feature/72182 wx runtime fixes (GH-79)
  • f1822fa Fix stale column headers after resize in Drawing Explorer grid (GH-81)
  • 27be88d Fix Drawing Explorer close button disappearing after moving a pane
  • 0e05118 AUI: wxAuiGenericTabArt re-add old means of detecting dark theme.
  • c71fef4 fix(osx/cocoa): centre icon in bitmap-only NSButton (GH-84)
  • d2701ab fix(msw): preserve combo popup size across DPI changes
  • 8e93a0e [arm64] Build wxWidgets for arm64 only on macOS
  • bde7b15 [arm64] Build wxWidgets for arm64 only on macOS
  • c5d173a Fix crash when opening compositions dialog (GH-88)
  • b8a8963 Improvements by Eugene Rukoleev.
  • 0fff60e Add support for generating Windows x86 binaries. (#89)
  • a4a3653 Reverted DoDrawPoint() to the 3.1.2 implementation

File Changes

(300 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/27045@github.com>

Iolanda Asavei

unread,
Sep 21, 2026, 1:32:02 PM (yesterday) Sep 21
to wx-...@googlegroups.com, Subscribed

Closed #27045.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/27045/issue_event/31547119309@github.com>

Reply all
Reply to author
Forward
0 new messages