Add window modality support to wxFrame (PR #26147)

4 views
Skip to first unread message

AliKet

unread,
Feb 1, 2026, 7:17:40 PM (7 hours ago) Feb 1
to wx-...@googlegroups.com, Subscribed

wxDialog already support modality:

https://github.com/wxWidgets/wxWidgets/blob/7ba5acc72c22d5cf36f33ac927b4b11f0ffa477e/include/wx/dialog.h#L54-L79

Therefore, the changes here are for wxFrame class.

If the API looks good, then I'll add a commit replacing #26137 and update the documentation.

TIA!


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/26147

Commit Summary

  • cfa5c51 Initialize wxFrameBase members in their declarations
  • f431f3e Add wxFrameBase::SetWindowModality() member function
  • 3c41f5b Add wxFrameBase::ShowWithModality() member function
  • 739fa6a Initialize wxPreviewFrame members in their declarations
  • 2e87e9e Re-define wxPreviewFrameModalityKind as an alias to wxFrameBase::ModalityKind
  • b9f2e09 Call the base class function to set the wxPreviewFrame modality
  • 654d814 Fix printing sample compilation after recent changes

File Changes

(5 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26147@github.com>

AliKet

unread,
1:30 AM (24 minutes ago) 1:30 AM
to wx-...@googlegroups.com, Push

@AliKet pushed 3 commits.

  • 6842621 Re-define wxPreviewFrameModalityKind as an alias to wxFrameBase::ModalityKind
  • 951dbe0 Call the base class function to set the wxPreviewFrame modality
  • 99d6d78 Fix printing sample compilation after recent changes


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26147/before/654d814f3c86a5234509b8283b9b1987a0eb13f6/after/99d6d78d3329091d090f62bbfc6cdce856a6e250@github.com>

Reply all
Reply to author
Forward
0 new messages