Draft PR SPH (PR #25821)
StevenPHirshman
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25821
Commit Summary
- 5d89d67 Update cshelp.cpp
- dc9078f Merge branch 'master' of https://github.com/StevenPHirshman/wxWidgets
- 45aefbf added virtual SetHelpEventPos
- d01f5a4 Replace SetHelpEventPos with SetHelpIdAtPoint
- 044b3b0 Delete include/wx/window.h
- 722cdc2 Delete src/common/cshelp.cpp
- 4fbc8f0 Delete src/common/tbarbase.cpp
- 8152db1 Delete src/common/wincmn.cpp
- e59b8b2 Delete include/wx/tbarbase.h
- 4298d6d updates for GetHelpIdFromPoint
- f3a84ce further updates
File Changes
(7 files)
- M include/wx/tbarbase.h (6)
- M include/wx/window.h (8)
- M interface/wx/event.h (5)
- M interface/wx/window.h (12)
- M src/common/cshelp.cpp (6)
- M src/common/tbarbase.cpp (11)
- M src/common/wincmn.cpp (3)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25821.patch
- https://github.com/wxWidgets/wxWidgets/pull/25821.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Closed #25821.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25821)Sorry, but I'm truly lost now. Just what exactly are you doing? I'll merge #25820 soon, why are you opening another PR (badly) duplicating it (with some extraneous whitespace changes)?
Please, please read GitHub documentation about using PRs and, also, using Git (there are a lot of good resources for this, I recommend the Git Book) because I have the impression that you don't quite understand how this works.
Also please try to train in your own repository, there is really no need to keep opening bad PRs in this one. Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
StevenPHirshman left a comment (wxWidgets/wxWidgets#25821)***@***.***
From: VZ ***@***.***>
Sent: Saturday, September 20, 2025 9:18 AM
To: wxWidgets/wxWidgets ***@***.***>
Cc: StevenPHirshman ***@***.***>; Author ***@***.***>
Subject: Re: [wxWidgets/wxWidgets] Draft PR SPH (PR #25821)
[Image removed by sender.]vadz left a comment (wxWidgets/wxWidgets#25821)<https://github.com/wxWidgets/wxWidgets/pull/25821#issuecomment-3314964929>
Sorry, but I'm truly lost now. Just what exactly are you doing? I'll merge #25820<https://github.com/wxWidgets/wxWidgets/pull/25820> soon, why are you opening another PR (badly) duplicating it (with some extraneous whitespace changes)?
Please, please read GitHub documentation about using PRs and, also, using Git (there are a lot of good resources for this, I recommend the Git Book<https://git-scm.com/book/en/v2>) because I have the impression that you don't quite understand how this works.
Also please try to train in your own repository, there is really no need to keep opening bad PRs in this one. Thanks!
—
You are receiving this because you authored the thread.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25821)How do I “train in my own repository”?
You push your branch (different from master) into your own fork and then open a PR against your own master. I believe this is explained in GitHub documentation, please check it.
P.S. And please stop quoting all this junk in your email replies, this is really not difficult.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.