Allow reusing POST data when using wxWebRequestCURL (PR #26048)
VZ
Set seek callback to allow libcurl to reuse the data being uploaded when it has to redo the HTTP request, e.g. because of redirection after a 301 or resubmitting it with correct authentication data after a 401.
Add a test checking that this works correctly, although it has to be disabled for WinHTTP for now as it doesn't handle 307/308 redirects automatically (see #26046).
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26048
Commit Summary
- c3cb1c1 Allow reusing POST data when using wxWebRequestCURL
File Changes
(3 files)
- M include/wx/private/webrequest_curl.h (3)
- M src/common/webrequest_curl.cpp (45)
- M tests/net/webrequest.cpp (24)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26048.patch
- https://github.com/wxWidgets/wxWidgets/pull/26048.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- 062af70 Send auth information provided in the URL preemptively
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26048)OK, so I've changed my mind myself after seeing the tests breakage. I'll add UseBasicAuth() instead to explicitly opt in into using it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 2 commits.
- 3c31dd5 Add wxWebCredentials::IsOk()
- 3baa046 Add support for preemptively using "Basic" HTTP authentication
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- 2be7895 Add support for preemptively using "Basic" HTTP authentication
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26048)I think this should be relatively uncontroversial now, but please let me know if anybody has any objections. Otherwise I'll merge this soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.