Re: CMake: silence shorten-64-to-32 warnings on macOS (PR #23331)

54 views
Skip to first unread message

VZ

unread,
Mar 10, 2023, 9:12:40 AM3/10/23
to wx-...@googlegroups.com, Subscribed

I thought it was just in stc.h, if it's also present in (many) other headers, disabling it globally is probably indeed the only thing to do...


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23331/c1463861815@github.com>

Tobias Taschner

unread,
Mar 10, 2023, 9:24:04 AM3/10/23
to wx-...@googlegroups.com, Subscribed

Just had a quick look: There are 252 warnings in wxSTC, 471 in wxCore, 107 in wxbase and a few in others.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23331/c1463876699@github.com>

VZ

unread,
Mar 12, 2023, 9:04:11 AM3/12/23
to wx-...@googlegroups.com, Subscribed

OK, merged now, thanks again.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23331/c1465193470@github.com>

VZ

unread,
Mar 12, 2023, 9:04:11 AM3/12/23
to wx-...@googlegroups.com, Subscribed

Closed #23331.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23331/issue_event/8725618994@github.com>

VZ

unread,
Mar 12, 2023, 10:31:11 AM3/12/23
to wx-...@googlegroups.com, Subscribed

This should probably be backported to 3.2 too, right?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23331/c1465213296@github.com>

Tobias Taschner

unread,
Mar 13, 2023, 4:37:42 AM3/13/23
to wx-...@googlegroups.com, Subscribed

This should probably be backported to 3.2 too, right?

Yes, would probably make sense as 3.2 would also be compiled with current Xcode versions.
The commit is probably directly applicable to 3.2.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23331/c1465717568@github.com>

VZ

unread,
Mar 13, 2023, 11:12:59 AM3/13/23
to wx-...@googlegroups.com, Subscribed

Thanks, it's part of #23344 now.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23331/c1466339213@github.com>

Reply all
Reply to author
Forward
0 new messages