Allow suppressing GTK log messages (PR #22424)
VZ
See #22176 for the motivation.
This will probably be used for other messages in the future.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/22424
Commit Summary
- f137f19 Factor out wxGTKImpl::LogFilter from GTKSuppressDiagnostics()
- 4602caf Add LogFilterByMessage GTK log filter
- 14416a7 Suppress bogus GTK messages when removing wxNotebook pages
- b9d3f73 Optionally detect not filtered GTK log messages
File Changes
(3 files)
- A include/wx/gtk/private/log.h (135)
- M src/gtk/app.cpp (113)
- M src/gtk/notebook.cpp (7)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/22424.patch
- https://github.com/wxWidgets/wxWidgets/pull/22424.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
PB
@PBfordev commented on this pull request.
> @@ -426,6 +427,12 @@ wxNotebookPage *wxNotebook::DoRemovePage( size_t page )
if ( !client )
return NULL;
+ // Suppress bogus assertion failures happening deel inside ATK that can't
⬇️ Suggested change
- // Suppress bogus assertion failures happening deel inside ATK that can't + // Suppress bogus assertion failures happening deep inside ATK that can't
Knowing nothing about Linux, I assume ATK (The Accessibility Toolkit ?) and not GTK is correct here...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
> @@ -426,6 +427,12 @@ wxNotebookPage *wxNotebook::DoRemovePage( size_t page )
if ( !client )
return NULL;
+ // Suppress bogus assertion failures happening deel inside ATK that can't
Oops, thanks for noticing. And yes, ATK (part/dependency of GTK) is indeed -- exceptionally -- not a typo :-)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@paulcor Please let me know if I should wait for your review. Otherwise I'll merge this soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Closed #22424.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Merged by the commit above.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.