MSW: Fix dark mode task dialog for elements that are not visible (PR #26953)
Steve Cornett
In dark mode, do not draw text elements for which get_CurrentIsOffscreen() returns false.
Fixes #26940.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26953
Commit Summary
- feccd76 Fix dark mode task dialog for elements that are not visible
File Changes
(1 file)
- M src/msw/taskdlg.cpp (14)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26953.patch
- https://github.com/wxWidgets/wxWidgets/pull/26953.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
PB
PBfordev left a comment (wxWidgets/wxWidgets#26953)Thanks, this deals with the broken layout but not (fully) with issue arising from moving the dialog to a screen with unscaled DPI:
Image: image (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Steve Cornett
stevecor left a comment (wxWidgets/wxWidgets#26953)It looks to me like getting the dark mode task dialog code to properly handle a DPI change event is not trivial. It was not written with this in mind. I'm not willing to tackle that. Note that it also does not properly handle switching between light and dark modes or high contrast mode.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26953)Thanks, will merge soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.