link error after adding d2d on MSW

[Andrey Turkin]

I have linker error after updating to r77560
{{{
link /DLL /NOLOGO /OUT:..\..\lib\vc_dll\wxmsw310ud_core_vc.dll /DEBUG
/pdb:"..\..\lib\vc_dll\wxmsw310ud_core_vc.pdb" /LIBPATH:..\..\lib\vc_dll
@C:\DOCUME~1\TURKIN~1.BAL\LOCALS~1\Temp\nm285F.tmp
Creating library ..\..\lib\vc_dll\wxmsw31ud_core.lib and object
..\..\lib\vc_dll\wxmsw31ud_core.exp
coredll_graphics.obj : error LNK2019: unresolved external symbol "public:
static class wxGraphicsRenderer * __cdecl
wxGraphicsRenderer::GetDirect2DRenderer(void)" (?
GetDirect2DRenderer@wxGraphicsRenderer@@SAPAV1@XZ) referenced in function
"public: static class wxGraphicsRenderer * __cdecl
wxGraphicsRenderer::GetDefaultRenderer(void)" (?
GetDefaultRenderer@wxGraphicsRenderer@@SAPAV1@XZ)
..\..\lib\vc_dll\wxmsw310ud_core_vc.dll : fatal error LNK1120: 1 unresolved
externals
}}}

It looks like makefile.vc wasn't updated

PS: I couldn't manage to create a new ticket on Trac,
It was rejected as spam :(

[Stefan Csomor]

Hi,

-----Ursprüngliche Nachricht-----
Von: Andrey Turkin <turk...@gmail.com>
Antworten an: "wx-...@googlegroups.com" <wx-...@googlegroups.com>
Datum: Dienstag, 9. September 2014 08:47
An: "wx-...@googlegroups.com" <wx-...@googlegroups.com>
Betreff: [wx-dev] link error after adding d2d on MSW

sorry, I must have made something wrong with upmake, makefile.vc wasn¹t
changed, I¹ll try to fix things

Thanks for your report,

Stefan

[Stefan Csomor]

Hi

>sorry, I must have made something wrong with upmake, makefile.vc wasn¹t
>changed, I¹ll try to fix things

had to run bakefile_gen , committed

Thanks,

Stefan

[Andrey Turkin]

Thank you very much Stefan. But now i have compile errors:

{{{
cl /c /nologo /TP /Fovc_mswuddll\coredll_graphicsd2d.obj /MDd
/DWIN32 /Zi /Fd..\..\lib\vc_dll\wxmsw310ud_core_vc.pdb /D_DEBUG /Od
/D_CRT_SECURE_NO_DEPRECATE=1 /D_CRT_NON_CONFORMING_SWPRINTFS=1
/D_SCL_SECURE_NO_WARNINGS=1 /D__WXMSW__ /D_UNICODE
/I..\..\lib\vc_dll\mswud /I..\..\include /W4 /DWXBUILDING
/I..\..\src\tiff\libtiff /I..\..\src\jpeg /I..\..\src\png /I..\..\src\zlib
/I..\..\src\regex /I..\..\src\expat\lib /DWXUSINGDLL /DWXMAKINGDLL_CORE
/DwxUSE_BASE=0 /GR /EHsc /Yu"wx/wxprec.h"
/Fp"vc_mswuddll\wxprec_coredll.pch" ..\..\src\msw\graphicsd2d.cpp
graphicsd2d.cpp
..\..\src\msw\graphicsd2d.cpp(1163) : error C2668: 'atan' : ambiguous call
to overloaded function
C:\Program Files\Microsoft Visual Studio
10.0\VC\INCLUDE\math.h(108): could be 'double atan(double)'
C:\Program Files\Microsoft Visual Studio
10.0\VC\INCLUDE\math.h(505): or 'float atan(float)'
C:\Program Files\Microsoft Visual Studio
10.0\VC\INCLUDE\math.h(553): or 'long double atan(long double)'
while trying to match the argument list '(int)'
..\..\src\msw\graphicsd2d.cpp(1557) : warning C4482: nonstandard extension
used: enum 'WICBitmapCreateCacheOption' used in qualified name
..\..\src\msw\graphicsd2d.cpp(2189) : error C2061: syntax error : identifier
'ID2D1Image'
..\..\src\msw\graphicsd2d.cpp(2193) : error C2065: 'offset' : undeclared
identifier
..\..\src\msw\graphicsd2d.cpp(2193) : error C2228: left of '.x' must have
class/struct/union
type is ''unknown-type''
..\..\src\msw\graphicsd2d.cpp(2193) : error C2065: 'offset' : undeclared
identifier
..\..\src\msw\graphicsd2d.cpp(2193) : error C2228: left of '.y' must have
class/struct/union
type is ''unknown-type''
..\..\src\msw\graphicsd2d.cpp(2193) : error C2065: 'offset' : undeclared
identifier
..\..\src\msw\graphicsd2d.cpp(2193) : error C2228: left of '.x' must have
class/struct/union
type is ''unknown-type''
..\..\src\msw\graphicsd2d.cpp(2193) : error C2065: 'imageRectangle' :
undeclared identifier
..\..\src\msw\graphicsd2d.cpp(2193) : error C2228: left of '.right' must
have class/struct/union
type is ''unknown-type''
..\..\src\msw\graphicsd2d.cpp(2193) : error C2065: 'offset' : undeclared
identifier
..\..\src\msw\graphicsd2d.cpp(2193) : error C2228: left of '.y' must have
class/struct/union
type is ''unknown-type''
..\..\src\msw\graphicsd2d.cpp(2193) : error C2065: 'imageRectangle' :
undeclared identifier
..\..\src\msw\graphicsd2d.cpp(2193) : error C2228: left of '.bottom' must
have class/struct/union
type is ''unknown-type''
..\..\src\msw\graphicsd2d.cpp(2195) : error C2065: 'image' : undeclared
identifier
..\..\src\msw\graphicsd2d.cpp(2198) : error C2065: 'interpolationQuality' :
undeclared identifier
..\..\src\msw\graphicsd2d.cpp(2199) : error C2065: 'imageRectangle' :
undeclared identifier
..\..\src\msw\graphicsd2d.cpp(3126) : error C2660:
'wxD2DRenderTargetResourceHolder::DrawBitmap' : function does not take 5
arguments
}}}

[Andrey Turkin]

Andrey Turkin <turkin60@...> writes:

>
> Stefan Csomor <csomor <at> ...> writes:
>
> >
> > Hi
> >
> > >sorry, I must have made something wrong with upmake, makefile.vc
wasn¹t
> > >changed, I¹ll try to fix things
> >
> > had to run bakefile_gen , committed
> >
> > Thanks,
> >
> > Stefan
> >
> Thank you very much Stefan. But now i have compile errors:
>

skip ...
>

OK,
I believe that a problem is here (line 789, setup0.h):

# if _MSC_VER >= 1500
# define wxUSE_GRAPHICS_DIRECT2D 1
# else
# define wxUSE_GRAPHICS_DIRECT2D 0
# endif

What is a reason to check for _MSC_VER 1500?
I tried to build r77563 with VS2010 (cl version 1600, SDK version 7.0
A) - it doesn't work,
and with VS2013 (cl version 1800, SDK version 8.1A) - it works fine.

May be it is necessary to check not the compiler version but the SDK
version?

[Bryan Petty]

On Tue, Sep 9, 2014 at 1:43 AM, Stefan Csomor
<cso...@advancedconcepts.ch> wrote:
> had to run bakefile_gen , committed

I think you missed a few builds files which I've just committed, let
me know if those don't belong in there. I needed those out of the way
for a clean bake of wxTaskBarButton up next.

--
Regards,
Bryan Petty

[Vadim Zeitlin]

On Tue, 9 Sep 2014 18:02:26 +0000 (UTC) Andrey Turkin wrote:

AT> I believe that a problem is here (line 789, setup0.h):
AT>
AT> # if _MSC_VER >= 1500
AT> # define wxUSE_GRAPHICS_DIRECT2D 1
AT> # else
AT> # define wxUSE_GRAPHICS_DIRECT2D 0
AT> # endif
AT>
AT> What is a reason to check for _MSC_VER 1500?

I believe this is the first version of MSVC that came with the SDK headers
new enough to have Direct2D support.

AT> I tried to build r77563 with VS2010 (cl version 1600, SDK version 7.0
AT> A) - it doesn't work,

How exactly doesn't it work with VC10?

AT> May be it is necessary to check not the compiler version but the SDK
AT> version?

This would be ideal, but I don't know how to do it.

Regards,
VZ

[Andrey Turkin]

Vadim Zeitlin <vadim@...> writes:

> I believe this is the first version of MSVC that came with the SDK
headers
> new enough to have Direct2D support.
>

What exactly SDK version is required?

> AT> I tried to build r77563 with VS2010 (cl version 1600, SDK version
7.0
> AT> A) - it doesn't work,
>
> How exactly doesn't it work with VC10?
>

Sorry if I was unclear. It just doesn't compile.
Errors are in this thread in the previous post.
Obviously, the reason in outdated SDK.

> AT> May be it is necessary to check not the compiler version but the SDK
> AT> version?
>
> This would be ideal, but I don't know how to do it.

:(

Thank you,
Andrey

[Bryan Petty]

On Wed, Sep 10, 2014 at 9:21 AM, Vadim Zeitlin <va...@wxwidgets.org> wrote:
> On Tue, 9 Sep 2014 18:02:26 +0000 (UTC) Andrey Turkin wrote:
>
> AT> I believe that a problem is here (line 789, setup0.h):
> AT>
> AT> # if _MSC_VER >= 1500
> AT> # define wxUSE_GRAPHICS_DIRECT2D 1
> AT> # else
> AT> # define wxUSE_GRAPHICS_DIRECT2D 0
> AT> # endif
> AT>
> AT> What is a reason to check for _MSC_VER 1500?
>
> I believe this is the first version of MSVC that came with the SDK headers
> new enough to have Direct2D support.
>
> AT> I tried to build r77563 with VS2010 (cl version 1600, SDK version 7.0
> AT> A) - it doesn't work,
>
> How exactly doesn't it work with VC10?

For what it's worth, I'm seeing the exact same compiler errors Andrey
mentioned, also using VC10.

--
Regards,
Bryan Petty

[David Connet]

>> AT> May be it is necessary to check not the compiler version but the SDK
>> AT> version?
>>

>> ZV> This would be ideal, but I don't know how to do it.


winsdkver.h may be helpful. But then it may not exist either...

I have VS2008 and 2012 installed on this machine:

>dir /s/b c:\Program Files (x86)\winsdkver.h
c:\Program Files (x86)\Microsoft SDKs\Windows\v7.1A\Include\winsdkver.h
c:\Program Files (x86)\Windows Kits\8.0\Include\um\winsdkver.h

>dir /s/b c:\Program Files\winsdkver.h
c:\Program Files\Microsoft SDKs\Windows\v7.1\Include\WinSDKVer.h


Dave

[Vadim Zeitlin]

On Wed, 10 Sep 2014 15:49:28 +0000 (UTC) Andrey Turkin wrote:

AT> Vadim Zeitlin <vadim@...> writes:
AT>
AT> > I believe this is the first version of MSVC that came with the SDK
AT> headers
AT> > new enough to have Direct2D support.
AT> >
AT> What exactly SDK version is required?

I don't know, but I thought v7.0A used by VC10 would be recent enough as
it does have d2d1.h. Apparently this is not the case though, as it lacks
ID2D1Image (and also has a couple of other errors unrelated to D2D itself).
I'm trying to fix this and will disable it for VC10 if I don't manage to.

Regards,
VZ

[Stefan Csomor]

Hi Bryan

sorry, I thought they were referring to the common project files, so I
only used format=msvc

Thanks a lot for your help,

Stefan

[Eric Jensen]

Hello Vadim,

Wednesday, September 10, 2014, 6:10:30 PM, you wrote:

VZ> On Wed, 10 Sep 2014 15:49:28 +0000 (UTC) Andrey Turkin wrote:

AT>> Vadim Zeitlin <vadim@...> writes:
AT>>
AT>> > I believe this is the first version of MSVC that came with the SDK
AT>> headers
AT>> > new enough to have Direct2D support.
AT>> >
AT>> What exactly SDK version is required?

VZ> I don't know, but I thought v7.0A used by VC10 would be recent enough as
VZ> it does have d2d1.h. Apparently this is not the case though, as it lacks
VZ> ID2D1Image (and also has a couple of other errors unrelated to D2D itself).
VZ> I'm trying to fix this and will disable it for VC10 if I don't manage to.

It does build with VS2010 as long as wxD2D_DEVICE_CONTEXT_SUPPORTED=0,
which is the default. The "drawing" sample doesn't work correctly
though. First of all the window is empty. When you're scrolling you
see that the content is actually drawn, but then it seems to get overdrawn
by the background color. Even worse, after around 30sec of
scrolling/resizing the window, you get an E_OUTOFMEMORY error in
wxD2DDCRenderTargetResourceHolder::DoAcquireResource().

Also, is there no way to make the wxD2D_DEVICE_CONTEXT_SUPPORTED
decision at runtime? I'd like to create executables that still work
under XP, but take advantage of new features when they're run
under Windows7/8.

Regards,
Eric

[Vadim Zeitlin]

On Thu, 11 Sep 2014 15:12:42 +0200 Eric Jensen wrote:

EJ> VZ> I don't know, but I thought v7.0A used by VC10 would be recent enough as
EJ> VZ> it does have d2d1.h. Apparently this is not the case though, as it lacks
EJ> VZ> ID2D1Image (and also has a couple of other errors unrelated to D2D itself).
EJ> VZ> I'm trying to fix this and will disable it for VC10 if I don't manage to.
EJ>
EJ> It does build with VS2010 as long as wxD2D_DEVICE_CONTEXT_SUPPORTED=0,
EJ> which is the default.

Yes, it does now as I've fixed the problems that prevented it from
building (r77665, r77666 and r77667).

EJ> The "drawing" sample doesn't work correctly though.

I've noticed this as well but didn't have time to debug it yet...

EJ> First of all the window is empty. When you're scrolling you
EJ> see that the content is actually drawn, but then it seems to get overdrawn
EJ> by the background color.

For me it remains completely empty until I turn *on* wxGraphicsContext
use. I don't understand at all what's going on here as by default
wxGraphicsContext is not used at all, so it looks that simply loading D2D
DLLs breaks GDI somehow :-(

EJ> Even worse, after around 30sec of scrolling/resizing the window, you
EJ> get an E_OUTOFMEMORY error in
EJ> wxD2DDCRenderTargetResourceHolder::DoAcquireResource().

Yes, there is clearly a huge memory leak somewhere as looking at the
"Working Set" column, it grows to ~1.5GiB before this assert happens.
Alexandru, if you're reading this, it would be really great if you could
try to debug this problem because it obviously makes it impossible to
enable D2D.

EJ> Also, is there no way to make the wxD2D_DEVICE_CONTEXT_SUPPORTED
EJ> decision at runtime?

There should be a way, but this hasn't been done. But, just to be sure
we're speaking about the same thing, wxD2D_DEVICE_CONTEXT_SUPPORTED is
minor, D2D use itself is determined during the run-time and the wx programs
should still run under XP (although I admit I haven't tested this, would be
nice if someone could) where they fall back on wxGDIPlusContext.

Regards,
VZ

[Andrey Turkin]

Vadim Zeitlin <vadim@...> writes:

> There should be a way, but this hasn't been done. But, just to be sure
> we're speaking about the same thing, wxD2D_DEVICE_CONTEXT_SUPPORTED is
> minor, D2D use itself is determined during the run-time and the wx
programs
> should still run under XP (although I admit I haven't tested this, would
be
> nice if someone could) where they fall back on wxGDIPlusContext.
>

I did try it under XP. It works with wxGDIPlusContext. It shows error log
window in debug build about missing DLLs for D2D, but it is OK

Andrey

[Vadim Zeitlin]

On Thu, 11 Sep 2014 16:59:14 +0000 (UTC) Andrey Turkin wrote:

AT> I did try it under XP. It works with wxGDIPlusContext. It shows error log
AT> window in debug build about missing DLLs for D2D, but it is OK

Hmm, no, this is not ok, it shouldn't be showing any errors when using
GetDefaultRenderer(). If you can see where it is coming from and fix it,
please post your patches here.

TIA,
VZ

[Andrey Turkin]

OK, patch is attached

{{{
Index: graphicsd2d.cpp
===================================================================
--- graphicsd2d.cpp (revision 77679)
+++ graphicsd2d.cpp (working copy)
@@ -128,8 +128,8 @@
private:
static bool LoadLibraries()
{
- m_dllDirect2d.Load(wxT("d2d1.dll"), wxDL_VERBATIM);
- m_dllDirectWrite.Load(wxT("dwrite.dll"), wxDL_VERBATIM);
+ m_dllDirect2d.Load(wxT("d2d1.dll"), wxDL_VERBATIM|wxDL_QUIET);
+ m_dllDirectWrite.Load(wxT("dwrite.dll"),
wxDL_VERBATIM|wxDL_QUIET);

bool hasDirect2dSupport = m_dllDirect2d.IsLoaded() &&
m_dllDirectWrite.IsLoaded();
}}}

And, at the same time, another one on a similar subject
(it complains about missing "ChangeWindowMessageFilter" under XP)

{{{
Index: frame.cpp
===================================================================
--- frame.cpp (revision 77679)
+++ frame.cpp (working copy)
@@ -162,6 +162,7 @@
wxDynamicLibrary dllUser32(wxT("user32.dll"));
if ( dllUser32.IsLoaded() )
{
+ wxLogNull logNo;
s_pfnChangeWindowMessageFilter =
(ChangeWindowMessageFilter_t)

dllUser32.GetSymbol(wxT("ChangeWindowMessageFilter"));
if ( s_pfnChangeWindowMessageFilter )
}}}

Andrey

[Vadim Zeitlin]

On Thu, 11 Sep 2014 18:27:33 +0000 (UTC) Andrey Turkin wrote:

AT> OK, patch is attached
AT>
AT> {{{
AT> Index: graphicsd2d.cpp
AT> ===================================================================
AT> --- graphicsd2d.cpp (revision 77679)
AT> +++ graphicsd2d.cpp (working copy)
AT> @@ -128,8 +128,8 @@
AT> private:
AT> static bool LoadLibraries()
AT> {
AT> - m_dllDirect2d.Load(wxT("d2d1.dll"), wxDL_VERBATIM);
AT> - m_dllDirectWrite.Load(wxT("dwrite.dll"), wxDL_VERBATIM);
AT> + m_dllDirect2d.Load(wxT("d2d1.dll"), wxDL_VERBATIM|wxDL_QUIET);
AT> + m_dllDirectWrite.Load(wxT("dwrite.dll"),
AT> wxDL_VERBATIM|wxDL_QUIET);
AT>
AT> bool hasDirect2dSupport = m_dllDirect2d.IsLoaded() &&
AT> m_dllDirectWrite.IsLoaded();
AT> }}}

Applied, thanks!

AT> And, at the same time, another one on a similar subject
AT> (it complains about missing "ChangeWindowMessageFilter" under XP)

I had already fixed this one in a slightly better way in r77681.

Regards,
VZ

[Eric Jensen]

Hello Vadim,

Thursday, September 11, 2014, 6:10:32 PM, you wrote:

VZ> For me it remains completely empty until I turn *on* wxGraphicsContext
VZ> use. I don't understand at all what's going on here as by default
VZ> wxGraphicsContext is not used at all, so it looks that simply loading D2D
VZ> DLLs breaks GDI somehow :-(
I think this is a bug in the sample. Even if m_useContext is false, a
wxGraphicsContext is still created in MyCanvas::Draw(). The code than
draws on the "normal" wxPaintDC which somehow seems to lie under the
Direct2D surface. (Just a wild guess, i didn't examine it in detail).

EJ>> Even worse, after around 30sec of scrolling/resizing the window, you
EJ>> get an E_OUTOFMEMORY error in
EJ>> wxD2DDCRenderTargetResourceHolder::DoAcquireResource().

VZ> Yes, there is clearly a huge memory leak somewhere as looking at the
VZ> "Working Set" column, it grows to ~1.5GiB before this assert happens.
VZ> Alexandru, if you're reading this, it would be really great if you could
VZ> try to debug this problem because it obviously makes it impossible to
VZ> enable D2D.
I think this is also caused by a bug in the sample, because above
mentioned context is not destroyed at the end of MyCanvas::Draw().

However, after fixing these two things, the initial display is ok, but
it throws exceptions later in an other part of the code when switching
to the "Mask" screen (F6). So i decided to leave this to the original
author.

I didn't make a patch for this, as the code is a little bit of a mess
with the wxUSE_GRAPHICS_CONTEXT and the addional check for
m_useContext at runtime. This may require some refactoring for a clean
solution.

Regards,
Eric

[Vadim Zeitlin]

On Fri, 12 Sep 2014 02:55:30 +0200 Eric Jensen wrote:

EJ> Thursday, September 11, 2014, 6:10:32 PM, you wrote:
EJ>
EJ> VZ> For me it remains completely empty until I turn on wxGraphicsContext
EJ> VZ> use. I don't understand at all what's going on here as by default
EJ> VZ> wxGraphicsContext is not used at all, so it looks that simply loading D2D
EJ> VZ> DLLs breaks GDI somehow :-(
EJ> I think this is a bug in the sample. Even if m_useContext is false, a
EJ> wxGraphicsContext is still created in MyCanvas::Draw(). The code than
EJ> draws on the "normal" wxPaintDC which somehow seems to lie under the
EJ> Direct2D surface. (Just a wild guess, i didn't examine it in detail).

Thank you, you're indeed correct and I've fixed this now (r77690). I've
also improved the sample to allow switching between GDI+ and Direct2D to
compare them more easily (r77692).

EJ> EJ>> Even worse, after around 30sec of scrolling/resizing the window, you
EJ> EJ>> get an E_OUTOFMEMORY error in
EJ> EJ>> wxD2DDCRenderTargetResourceHolder::DoAcquireResource().
EJ>
EJ> VZ> Yes, there is clearly a huge memory leak somewhere as looking at the
EJ> VZ> "Working Set" column, it grows to ~1.5GiB before this assert happens.
EJ> VZ> Alexandru, if you're reading this, it would be really great if you could
EJ> VZ> try to debug this problem because it obviously makes it impossible to
EJ> VZ> enable D2D.
EJ> I think this is also caused by a bug in the sample, because above
EJ> mentioned context is not destroyed at the end of MyCanvas::Draw().

No, this was a bona fide memory leak in the code (see r77693).

EJ> However, after fixing these two things, the initial display is ok, but
EJ> it throws exceptions later in an other part of the code when switching
EJ> to the "Mask" screen (F6). So i decided to leave this to the original
EJ> author.

This seems to not work with GDI+ neither, not sure what's going on here.


But Direct2D renderer has two problems which are much worse, see
https://github.com/alexpana/wxWidgets/issues/18 and
https://github.com/alexpana/wxWidgets/issues/19. Until this is fixed, I've
disabled its use by default.

Regards,
VZ