Fix Tab navigation into generic wxInfoBar (PR #27052)
Quin Gillespie
The generic wxInfoBar was a plain wxControl, not a container, so Tab gave focus to the info bar window itself and never moved to the close button or other buttons inside it. Screen readers only announced "panel".
wxInfoBarGeneric now derives from wxNavigationEnabled, the same as wxGenericCollapsiblePane, so Tab moves to the buttons inside it.
Tested with NVDA on Windows 11.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/27052
Commit Summary
- dcfe7fd fix Tab navigation into generic wxInfoBar
File Changes
(1 file)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/27052.patch
- https://github.com/wxWidgets/wxWidgets/pull/27052.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27052)I've actually never thought about giving wxInfoBar focus from keyboard, but it makes sense to let the user navigate inside if this happens, of course, thanks!
Will also merge soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27052)BTW, shouldn't we change its name so that it could be announced as "info bar" and not "panel"?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Quin Gillespie
trypsynth left a comment (wxWidgets/wxWidgets#27052)It's not announced as "panel" any more: with this PR the info bar doesn't get focus itself, so focus goes directly to the close button. And #27053 gives it the alert role, with the message as its name, so with both PRs NVDA says "This is an info bar message, alert" followed by "Hide this notification message. button" when tabbing into it.
There is no specific "info bar" role, and alert seems to be the closest one (it's also what the web uses for such notifications, role="alert"). I think the message is more useful as the name than "info bar" would be, but we could use "Info bar" as the description if you think it's worth it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.