OSX Toggle Button Styling (PR #26308)
Stefan Csomor
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26308
Commit Summary
- a9c12e1 use common method for toggle and normal buttons
File Changes
(3 files)
- M include/wx/osx/cocoa/private.h (7)
- M src/osx/cocoa/button.mm (35)
- M src/osx/cocoa/tglbtn.mm (52)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26308.patch
- https://github.com/wxWidgets/wxWidgets/pull/26308.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- edd2bc9 fix whitespace
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- d87de50 using NSShadowlessSquareBezelStyle for toggles like before
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26308)Should this be merged or do you plan more changes here?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
csomor left a comment (wxWidgets/wxWidgets#26308)Should this be merged or do you plan more changes here?
wait a moment please, we have to decide whether to move forward, using a rounded style, or keeping the old look, and I want to document how to arrive at another style for a toggle button as well ...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- d779412 Revert "using NSShadowlessSquareBezelStyle for toggles like before"
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
Thanks, just to confirm: should this one be merged now or should we wait more for it to be tested?
> @@ -187,6 +199,7 @@ - (NSControlSize)controlSize;
{
NSButton* button = GetNSButton();
[button setAlternateImage: wxOSXGetImageFromBundle(bitmap)];
+ NSLog(@"alternateImage height %d, normalImage height %d", (int)[button alternateImage].size.height, (int)[button image].size.height);
This should probably be removed?
In include/wx/osx/cocoa/private.h:
> @@ -50,7 +50,12 @@ wxBitmapBundle WXDLLIMPEXP_CORE wxOSXCreateSystemBitmapBundle(const wxString& id WXWindow WXDLLIMPEXP_CORE wxOSXGetMainWindow(); WXWindow WXDLLIMPEXP_CORE wxOSXGetKeyWindow(); WXImage WXDLLIMPEXP_CORE wxOSXGetNSImageFromNSCursor(const WXHCURSOR cursor); - +void WXDLLIMPEXP_CORE wxOSXSetBezelStyleFromBorderFlags(WX_NSButton v,
Is WXDLLIMPEXP_CORE really needed here? I.e. is it really going to be used from outside the core library? I think it doesn't need to be exported from it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor commented on this pull request.
In include/wx/osx/cocoa/private.h:
> @@ -50,7 +50,12 @@ wxBitmapBundle WXDLLIMPEXP_CORE wxOSXCreateSystemBitmapBundle(const wxString& id WXWindow WXDLLIMPEXP_CORE wxOSXGetMainWindow(); WXWindow WXDLLIMPEXP_CORE wxOSXGetKeyWindow(); WXImage WXDLLIMPEXP_CORE wxOSXGetNSImageFromNSCursor(const WXHCURSOR cursor); - +void WXDLLIMPEXP_CORE wxOSXSetBezelStyleFromBorderFlags(WX_NSButton v,
you are right, I'll change that
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor commented on this pull request.
> @@ -187,6 +199,7 @@ - (NSControlSize)controlSize;
{
NSButton* button = GetNSButton();
[button setAlternateImage: wxOSXGetImageFromBundle(bitmap)];
+ NSLog(@"alternateImage height %d, normalImage height %d", (int)[button alternateImage].size.height, (int)[button image].size.height);
yes, I'll do that
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- accb114 removing unnecessary export and debug log
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
csomor left a comment (wxWidgets/wxWidgets#26308)Thanks, just to confirm: should this one be merged now or should we wait more for it to be tested?
fine to merge for me, we need broad testing now, if we run into trouble, I'll re-add the last reverted commit, which makes things less beautiful
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.