Fix showing `wxProgressDialog` with `wxPD_CAN_SKIP` in wxMSW (PR #26293)

25 views
Skip to first unread message

VZ

unread,
Mar 14, 2026, 8:47:24 PM (3 days ago) Mar 14
to wx-...@googlegroups.com, Subscribed

Also make this code more robust.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/26293

Commit Summary

  • 2a43183 Return true from wxProgressDialog::Show() on success
  • c76e4ff Remove unnecessary explicit call to wxThread::Create()
  • 505aa61 Remove untranslated error message never shown in practice
  • 7506289 Fall back to generic dialog if native wxProgressDialog fails
  • 82632d6 Fix showing wxProgressDialog with wxPD_CAN_SKIP style

File Changes

(2 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26293@github.com>

VZ

unread,
Mar 16, 2026, 8:25:08 PM (2 days ago) Mar 16
to wx-...@googlegroups.com, Subscribed
vadz left a comment (wxWidgets/wxWidgets#26293)

I'll merge this soon even in absence of feedback because it fixes a user-visible bug.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26293/c4071497734@github.com>

VZ

unread,
Mar 17, 2026, 9:22:04 AM (17 hours ago) Mar 17
to wx-...@googlegroups.com, Subscribed

Merged #26293 into master.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26293/issue_event/23643769272@github.com>

Reply all
Reply to author
Forward
0 new messages