msw/listctrl: Fix more text overflow and column overflow issues (PR #26558)
Crementif
In my previous PR (#25950), I tried to fix a few issues I was seeing from our usage of the wxListCtrl for our game list in Cemu. But I noticed a new regression after updating to wxWidgets 3.3.2.
It turns out that due to an unrelated change in #25962, an existing issue related to calculating the width of a row element was uncovered. This PR addresses the root cause of that uncovered bug, but also fixes another tell that was there to point towards this always having been an issue. But here were the symptoms.
- Columns being misaligned with their contents.
- Headers not being aligned with their content due to using an image.
- Probably other things that I hadn't noticed before, which caused different behavior between the two platforms.
Screenshots
Here's the game list compiled with 3.3.2:
image.png (view on web)
You can see that text truncation is broken, and the headers and rows are not aligned correctly, which did work in the version compiled with my PR:
image.png (view on web)However, with the version of my previous PR, although it does not have the column misalignment regression that was added in 3.3.2, it still has the issue of the text being incorrectly truncated. I'm listing this not to point blame, but just to retrace my steps in the hopes of making this change more understandable and valid.
So, the fixed version has proper truncation and the row columns appear to correctly work too. I tested it with the white mode, and the ellipses amount changing also appears to be correct.
https://github.com/user-attachments/assets/6c4cfdf4-c8f9-4f4b-9f67-f709f2ab614c
Small disclaimer: I did work on this patch in March. As far as I'm aware however, the behavior is still there and I really do think that this is just correcting a wrong function signature causing havoc.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26558
Commit Summary
- 1b104e8 msw/listctrl: Fix text overflow and column overflow
File Changes
(1 file)
- M src/msw/listctrl.cpp (21)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26558.patch
- https://github.com/wxWidgets/wxWidgets/pull/26558.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26558)Thanks, the change looks reasonable to me, so I'll merge it soon even though the interplay with #25962 is not clear to me.
@MaartenBent Please let me know if you have any comments.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26558)Looks good to me. I don't see any regressions in the listctrl example.
I also don't see how #25962 could be related, it only affects what attributes (colour, font) are used for drawing a cell.
If I have to guess, this could be the culprit: b2ada52 . But that was necessary to fix the drawing issues shown in the screenshot here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.