Add GetHWND() to wxWindowGTK when on Windows (PR #24675)
Ryan Ogurek
As the title says, when using wxGTK on Windows there's not a way (that I can tell) to get an HWND from a wxWindow. This uses a couple of gdk and gtk helpers to get the HWND from the underlying GtkWidget.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/24675
Commit Summary
- 857e5e9 Add GetHWND() to wxWindowGTK when on Windows
File Changes
(2 files)
- M include/wx/gtk/window.h (3)
- M src/gtk/window.cpp (11)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/24675.patch
- https://github.com/wxWidgets/wxWidgets/pull/24675.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Ryan Ogurek
To give some context as to why I want this (although I'm sure there's plenty of other uses), in order to set the title bar to be dark when GTK_CSD=0 (And I always turn CSD off... it's awful under windows), the window's HWND is required:
#ifdef __WINDOWS__ DWORD useDarkMode{Misc::getTheme() == Misc::Theme::DARK_MODE}; DwmSetWindowAttribute( GetHWND(), DWMWINDOWATTRIBUTE::DWMWA_USE_IMMERSIVE_DARK_MODE, &useDarkMode, sizeof(DWORD) ); #endif
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
Thanks, I don't think there is a problem with adding such a function but I'm not sure about the name and it should also be documented in interface/wx/window.h if we mean it to be part of the public API now.
> @@ -4240,6 +4243,14 @@ bool wxWindowGTK::GTKShowFromOnIdle()
return false;
}
+#ifdef __WINDOWS__
+WXHWND wxWindowGTK::GetHWND() const {
Very minor, but wx style is to put braces on their own lines, i.e.
⬇️ Suggested change-WXHWND wxWindowGTK::GetHWND() const {
+WXHWND wxWindowGTK::GetHWND() const
+{
> @@ -139,6 +139,9 @@ class WXDLLIMPEXP_CORE wxWindowGTK : public wxWindowBase
// --------------
virtual WXWidget GetHandle() const override { return m_widget; }
+#ifdef __WINDOWS__
+ WXHWND GetHWND() const;
I'm not sure if it's a good or bad idea to use the same name as for the existing function in wxMSW. On one hand, this would allow referring to it without checking for __WXGTK__ but OTOH do we really plan to have much code using either wxMSW or wxGTK and having to manipulate the underlying HWND directly?
Perhaps we should call this GTKGetWin32Handle() instead? Granted, this is much longer but this shouldn't be used very often, hopefully.
> + // There isn't an underlying HWND if the widget hasn't been realized yet. + gtk_widget_realize(m_widget);
This is more serious, IMO it's really unexpected for an accessor like this to have significant side effects.
Would it be a problem to just call this function only if the window had been already realized?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Ryan Ogurek
@ryancog pushed 1 commit.
- c3e5f31 Fix wxWindowGTK::GetHWND() styling
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Ryan Ogurek
@ryancog commented on this pull request.
> @@ -4240,6 +4243,14 @@ bool wxWindowGTK::GTKShowFromOnIdle()
return false;
}
+#ifdef __WINDOWS__
+WXHWND wxWindowGTK::GetHWND() const {
Whoops, my bad... I didn't realize the difference in styling it seems.
Fixed
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Ryan Ogurek
@ryancog commented on this pull request.
> @@ -139,6 +139,9 @@ class WXDLLIMPEXP_CORE wxWindowGTK : public wxWindowBase
// --------------
virtual WXWidget GetHandle() const override { return m_widget; }
+#ifdef __WINDOWS__
+ WXHWND GetHWND() const;
but OTOH do we really plan to have much code using either wxMSW or wxGTK and having to manipulate the underlying
HWNDdirectly?
I can't imagine so.
Perhaps we should call this
GTKGetWin32Handle()instead? Granted, this is much longer but this shouldn't be used very often, hopefully.
Making it a different, distinguishable name makes sense to me.
Mostly out of curiousity, what's the logic stylistically behind prefixing it with GTK?
Since there's other wxWindowGTK functions that aren't...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Ryan Ogurek
@ryancog commented on this pull request.
> + // There isn't an underlying HWND if the widget hasn't been realized yet. + gtk_widget_realize(m_widget);
Would need to add an extra check on the first gtk function, since it'll return null if not (and passing that to gdk will cause bad things), but that's easy enough.
However, that'd require a way (for my use case at least) to be able to realize the GTK Window through wxWidgets. I'll see if there's a function for that already. If not, I'd want to add one.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Ryan Ogurek
@ryancog commented on this pull request.
> + // There isn't an underlying HWND if the widget hasn't been realized yet. + gtk_widget_realize(m_widget);
I don't see a method to "force" realize a gtk window.
Are you aware if there's something like this that exists and/or what sort of side effects would need to be considered by creating another function (GTKRealizeWidget() for example) to do this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Ryan Ogurek
it should also be documented in interface/wx/window.h if we mean it to be part of the public API now.
Should it go in interface/wx/window.h or into a gtk specific one? That file currently seems to be entirely platform-agnostic functions, so I'm not sure how to go about adding that documentation.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Ryan Ogurek
@ryancog pushed 1 commit.
- ce10085 Rename wxWindowGTK::GetHWND() to GTKGetWin32Handle(), add GTKRealizeWidget()
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.