Add missing null check in wxAffineMatrix2D::Get (PR #26303)
Serdar Pehlivan
Variable "mat2D" wasn't being checked for null, despite "tr" was checked for it.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26303
Commit Summary
- 03627b3 Add missing null check in wxAffineMatrix2D::Get
File Changes
(1 file)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26303.patch
- https://github.com/wxWidgets/wxWidgets/pull/26303.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26303)This is consistent with the documentation, see interface/wx/affinematrix2dbase.h
/** Get the component values of the matrix. @param mat2D The rotational components of the matrix (upper 2 x 2), must be non-null. @param tr The translational components of the matrix, may be @NULL. */ virtual void Get(wxMatrix2D* mat2D, wxPoint2DDouble* tr) const = 0;
Crashing is still not very user-friendly, but AFAICS it makes no sense to call this function with null matrix (do you do it intentionally?), so we should probably add a wxCHECK_RET() to it, but not silently ignore the invalid calls.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Serdar Pehlivan
SerdarPe left a comment (wxWidgets/wxWidgets#26303)It occured when I wanted to get just the translation part of the affine matrix. I didn't need the transformation matrix in that specific part of my code.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26303)OK, but then we need to update the documentation (under interface/wx) to not say that this parameter is required any longer, could you please do it?
And I'd still add at least a wxASSERT_MSG() checking that both of parameters are not null at the same time.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Serdar Pehlivan
@SerdarPe pushed 1 commit.
- ec2d139 Update documentation for wxAffineMatrix2D::Get
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Serdar Pehlivan
@SerdarPe pushed 1 commit.
- 2b1929b Update documentation for wxAffineMatrix2D::Get
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Serdar Pehlivan
@SerdarPe pushed 1 commit.
- bceefa8 Add missing null check in wxAffineMatrix2D::Get
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Serdar Pehlivan
SerdarPe left a comment (wxWidgets/wxWidgets#26303)Alright, I've updated the commit.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26303)Thanks, will merge soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.