Fix static build regression on GTK (wxMoveToTrash) (PR #26290)
Blake-Madden
Static builds on Linux (GTK), wxMoveToTrash will cause a link error because the stub version will be included in wx::base (because __GTK__ isn't defined), but then the actual GTK implementation is built into wx::core (where __GTK__ is defined; this is all because of the GIO dependency).
So we need to ensure that under GTK, only the actual GTK function is compiled (into wx::core) and the stub is left out. Under macOS and Windows, it continues to be built into wx::base.
This does mean that if wxHAS_MOVE_TO_TRASH is not defined, then this function will not be available now. IMO, that actually seems better than a stub function that silently fails.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26290
Commit Summary
- c9ebb8d Fix static build regression on GTK (wxMoveToTrash)
File Changes
(3 files)
- M include/wx/filefn.h (8)
- M interface/wx/filefn.h (3)
- M src/common/filefn.cpp (9)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26290.patch
- https://github.com/wxWidgets/wxWidgets/pull/26290.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.