Fix wxCollapsibleHeaderCtrl accessibility and Enter key under MSW (PR #27048)
Quin Gillespie
The generic collapsible header, used by wxCollapsiblePane and so by the generic about dialog, had two problems for keyboard and screen reader users under MSW:
- Pressing Enter on the header activated the default button of the dialog. In wxAboutBox this closed the dialog. Enter now toggles the header, the same as Space.
- Screen readers could not tell what the header was or if it was open. It now reports itself as a button with an expanded or collapsed state, sends a state change event when it toggles, and has a default action.
Tested with NVDA on Windows 11: the header now reads as "button collapsed" or "button expanded", and Enter toggles it without closing the about dialog.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/27048
Commit Summary
- 4160e2f fix wxCollapsibleHeaderCtrl accessibility and Enter key handling under MSW
File Changes
(2 files)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/27048.patch
- https://github.com/wxWidgets/wxWidgets/pull/27048.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27048)Implementing a11y support for the header is very welcome, thank you!
But I wonder about "Enter" — do we really need it to toggle the header? I think "Space" should be already doing this, and not using "Enter" for this would avoid the need for MSW-specific code.
And if we do need it, using wxWANTS_CHARS should be a better way to let it have "Enter".
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Quin Gillespie
trypsynth left a comment (wxWidgets/wxWidgets#27048)Thanks for looking at this!
I think Enter is worth keeping. Now that the header reports itself as a button, screen reader users hear "button" and expect Enter to press it, like it does for any focused button under MSW (and like the existing code in wxWindowMSW::MSWProcessMessage() ensures for wxButton, which gets Enter even when there is a default button elsewhere). Without it, Enter on the header activates the default button instead, which in wxAboutBox closes the whole dialog. That's how I found this in the first place.
I'll switch to wxWANTS_CHARS and drop the MSW-specific code. The header will then also get Tab, so I'll call HandleAsNavigationKey() for it in OnChar() to keep Tab navigation working. The only other difference I see is that arrow keys won't move to the next control from the header any more, which seems fine to me, but please let me know if you think otherwise.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Quin Gillespie
@trypsynth pushed 1 commit.
- f87ff32 fix Enter handling in wxCollapsibleHeaderCtrl using wxWANTS_CHARS
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.