Don't use /MP option when not using MSVS CMake generator (PR #26392)
VZ
It is useless in this case as make/Ninja generators only compile a single file at once anyhow and can also be harmful when using clang-cl compiler which gives warnings about unsupported option.
@MaartenBent Please let me know if you have any objections or see a better way to do this, but I need some way to fix it to avoid getting warnings about unrecognized option for every source file when using clang-cl.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26392
Commit Summary
- 9a15037 Don't use /MP option when not using MSVS CMake generator
File Changes
(1 file)
- M build/cmake/init.cmake (2)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26392.patch
- https://github.com/wxWidgets/wxWidgets/pull/26392.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26392)I think this is the best way to do it, as using MSVC alone is not enough.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26392)Applied in the commit above.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.